Update tracing to collect from reasons #29975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
styfle
reviewed
Oct 18, 2021
styfle
previously approved these changes
Oct 18, 2021
styfle
approved these changes
Oct 18, 2021
Stats from current PRDefault BuildGeneral Overall increase
|
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| buildDuration | 16.5s | 16.5s | |
| buildDurationCached | 3.8s | 3.8s | |
| nodeModulesSize | 195 MB | 195 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.86 | 3.849 | -0.01 |
| / avg req/sec | 647.72 | 649.48 | +1.76 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 2.078 | 2.078 | ✓ |
| /error-in-render avg req/sec | 1203.2 | 1203.18 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| 558.HASH.js gzip | 3.02 kB | 3.02 kB | ✓ |
| 779.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 25 kB | 25 kB | ✓ |
| webpack-HASH.js gzip | 1.49 kB | 1.49 kB | ✓ |
| Overall change | 71.9 kB | 71.9 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 977 B | 977 B | ✓ |
| _error-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
| amp-HASH.js gzip | 553 B | 553 B | ✓ |
| css-HASH.js gzip | 328 B | 328 B | ✓ |
| dynamic-HASH.js gzip | 2.73 kB | 2.73 kB | ✓ |
| head-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
| hooks-HASH.js gzip | 918 B | 918 B | ✓ |
| image-HASH.js gzip | 5.86 kB | 5.86 kB | ✓ |
| index-HASH.js gzip | 260 B | 260 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 19.9 kB | 19.9 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 490 B | 490 B | ✓ |
| Overall change | 490 B | 490 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| index.html gzip | 539 B | 539 B | ✓ |
| link.html gzip | 551 B | 551 B | ✓ |
| withRouter.html gzip | 533 B | 533 B | ✓ |
| Overall change | 1.62 kB | 1.62 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| buildDuration | 8.1s | 8s | -121ms |
| buildDurationCached | 3.7s | 3.9s | |
| nodeModulesSize | 195 MB | 195 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.85 | 3.882 | |
| / avg req/sec | 649.42 | 644.04 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 2.058 | 2.104 | |
| /error-in-render avg req/sec | 1214.85 | 1188.4 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| 675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
| 770.HASH.js gzip | 178 B | 178 B | ✓ |
| framework-HASH.js gzip | 50.8 kB | 50.8 kB | ✓ |
| main-HASH.js gzip | 35.2 kB | 35.2 kB | ✓ |
| webpack-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| Overall change | 102 kB | 102 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 315 B | 315 B | ✓ |
| css-HASH.js gzip | 331 B | 331 B | ✓ |
| dynamic-HASH.js gzip | 2.79 kB | 2.79 kB | ✓ |
| head-HASH.js gzip | 355 B | 355 B | ✓ |
| hooks-HASH.js gzip | 637 B | 637 B | ✓ |
| image-HASH.js gzip | 555 B | 555 B | ✓ |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 2.22 kB | 2.22 kB | ✓ |
| routerDirect..HASH.js gzip | 326 B | 326 B | ✓ |
| script-HASH.js gzip | 393 B | 393 B | ✓ |
| withRouter-HASH.js gzip | 322 B | 322 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 510 B | 510 B | ✓ |
| Overall change | 510 B | 510 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ijjk/next.js update/patch-tracing-cases | Change | |
|---|---|---|---|
| index.html gzip | 538 B | 538 B | ✓ |
| link.html gzip | 551 B | 551 B | ✓ |
| withRouter.html gzip | 533 B | 533 B | ✓ |
| Overall change | 1.62 kB | 1.62 kB | ✓ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
outputFileTracingto fix a few cases we noticed where files weren't caught and also ensures we match webpack'sesmresolving so that we don't includecjsfiles when webpack expectsesm, it also updates to the latest@vercel/nftversion which removes the caching in favor of ensuring thereasonsmap contains all parents allowing us to trace all entries in onenodeFileTracerun and the collect the separate files for each entry from thereasonsmap giving us much better performance/reliability.This also ensures we don't include static image imports when enabled in the traces since they can drastically increase deployment size on larger projects.