Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #29969

Merged
merged 9 commits into from
Oct 17, 2021
Merged

Update swc #29969

merged 9 commits into from
Oct 17, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 16, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

  • Throw an exception on panic.

  • Fix hashing of styled jsx.

  • Handle of jsx escapes correctly.

Created again to purge cache.

const A = ()=><div className={"jsx-f44d626e14f3cfbc"}>

<p className={"jsx-f44d626e14f3cfbc"}>test</p>

Copy link
Member

@styfle styfle Oct 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the additional newline expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's an unminified, normalized output of transform. It does not matter in real output.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 16, 2021

Failing test suites

Commit: bbae0fb

test/development/basic/hmr.test.ts

  • basic HMR > Error Recovery > should recover after undefined exported as default
Expand output

● basic HMR › Error Recovery › should recover after undefined exported as default

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:614:8)

test/integration/preload-viewport/test/index.test.js

  • Prefetching Links in viewport > should not prefetch already loaded scripts
Expand output

● Prefetching Links in viewport › should not prefetch already loaded scripts

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  378 |     expect(hrefs).toEqual([...new Set(hrefs)])
  379 |
> 380 |     // Verify encoding
      |     ^
  381 |     expect(hrefs.some((e) => e.includes(`%5Bhello%5D-`))).toBe(true)
  382 |   })
  383 |

  at Object.<anonymous> (integration/preload-viewport/test/index.test.js:380:5)

@kdy1 kdy1 marked this pull request as draft October 17, 2021 06:04
@kdy1 kdy1 marked this pull request as ready for review October 17, 2021 06:26
@ijjk
Copy link
Member

ijjk commented Oct 17, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-2 Change
buildDuration 12.4s 12.7s ⚠️ +271ms
buildDurationCached 3s 3.1s ⚠️ +135ms
nodeModulesSize 199 MB 198 MB -763 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-2 Change
/ failed reqs 0 0
/ total time (seconds) 2.858 2.852 -0.01
/ avg req/sec 874.83 876.43 +1.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.307 1.351 ⚠️ +0.04
/error-in-render avg req/sec 1912.78 1850.04 ⚠️ -62.74
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-2 Change
558.HASH.js gzip 3.02 kB 3.02 kB
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 25 kB 25 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-2 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-2 Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 3.11 kB 3.11 kB
amp-HASH.js gzip 553 B 553 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.73 kB 2.73 kB
head-HASH.js gzip 2.37 kB 2.37 kB
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 5.86 kB 5.86 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.9 kB 19.9 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-2 Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-2 Change
index.html gzip 538 B 538 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-ver-2 Change
buildDuration 6.3s 6.2s -37ms
buildDurationCached 2.9s 2.9s -32ms
nodeModulesSize 199 MB 198 MB -763 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-ver-2 Change
/ failed reqs 0 0
/ total time (seconds) 2.91 2.898 -0.01
/ avg req/sec 859.24 862.76 +3.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.314 1.278 -0.04
/error-in-render avg req/sec 1902.59 1956.45 +53.86
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-2 Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.8 kB 50.8 kB
main-HASH.js gzip 35.2 kB 35.2 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 102 kB 102 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-2 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-2 Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-2 Change
_buildManifest.js gzip 510 B 510 B
Overall change 510 B 510 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-2 Change
index.html gzip 538 B 538 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 0d90022

@timneutkens timneutkens merged commit a3fcebc into vercel:canary Oct 17, 2021
@timneutkens timneutkens deleted the swc-ver-2 branch October 17, 2021 07:50
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants