Update swc & Improve CI time #29884

kdy1 · 2021-10-13T15:10:39Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes

sokra · 2021-10-13T15:22:58Z

.github/workflows/build_native.yml

+        uses: actions/cache@v1
+        with:
+          path: ./packages/next/build/swc/target
+          key: next-swc-cargo-cache-${{ matrix.os }}--${{ hashFiles('**/Cargo.lock') }}


Note that it won't upload a new cache when Cargo.lock is identical. So you will only create a new cache entry when the Cargo.lock changes.

I think it's fine, as compile times are mainly due to dependency crates, like swc

ijjk · 2021-10-13T16:11:02Z

Failing test suites

Commit: 879e5a9

test/development/basic/hmr.test.ts

basic HMR > Error Recovery > should recover from errors in the render function
basic HMR > Error Recovery > should recover after a bad return from the render function
basic HMR > Error Recovery > should recover after undefined exported as default

Expand output

● basic HMR › Error Recovery › should recover from errors in the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:455:9)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:558:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after undefined exported as default 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about7"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  600 |         await next.patchFile(aboutPage, aboutContent)
  601 |
> 602 |         if (browser) {
      |                       ^
  603 |           await check(
  604 |             () => getBrowserBodyText(browser),
  605 |             /This is the about page/

  at Object.<anonymous> (development/basic/hmr.test.ts:602:23)

.github/workflows/build_native.yml

Co-authored-by: JJ Kasper <jj@jjsweb.site>

ijjk · 2021-10-13T16:40:48Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js ci-time	Change
buildDuration	12.2s	12.1s	-60ms
buildDurationCached	2.9s	2.9s	-11ms
nodeModulesSize	200 MB	200 MB	⚠️ +1 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kdy1/next.js ci-time	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.754	2.71	-0.04
/ avg req/sec	907.78	922.48	+14.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.281	1.297	⚠️ +0.02
/error-in-render avg req/sec	1952.27	1927.73	⚠️ -24.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js ci-time	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.9 kB	70.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js ci-time	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js ci-time	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js ci-time	Change
_buildManifest.js gzip	493 B	493 B	✓
Overall change	493 B	493 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js ci-time	Change
index.html gzip	538 B	538 B	✓
link.html gzip	550 B	550 B	✓
withRouter.html gzip	532 B	532 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js ci-time	Change
buildDuration	6.1s	6.1s	✓
buildDurationCached	2.9s	2.9s	⚠️ +17ms
nodeModulesSize	200 MB	200 MB	⚠️ +1 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kdy1/next.js ci-time	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.741	2.756	⚠️ +0.01
/ avg req/sec	911.97	907.27	⚠️ -4.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.281	1.326	⚠️ +0.05
/error-in-render avg req/sec	1952.16	1885.45	⚠️ -66.71

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js ci-time	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	35 kB	35 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js ci-time	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js ci-time	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	355 B	355 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	555 B	555 B	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.22 kB	2.22 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js ci-time	Change
_buildManifest.js gzip	512 B	512 B	✓
Overall change	512 B	512 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js ci-time	Change
index.html gzip	537 B	537 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: 90f458f

Speed up ci

63421b1

sokra reviewed Oct 13, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Build next-swc binaries

eaa7e2e

ijjk added the type: next label Oct 13, 2021

Merge branch 'canary' into ci-time

93d217b

This comment has been minimized.

Sign in to view

kdy1 and others added 2 commits October 14, 2021 00:53

fix

879e5a9

Build next-swc binaries

d14ced7

This comment has been minimized.

Sign in to view

Fix pass ordering

d63741b

kdy1 marked this pull request as ready for review October 13, 2021 16:24

kdy1 requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners October 13, 2021 16:24

ijjk reviewed Oct 13, 2021

View reviewed changes

.github/workflows/build_native.yml Outdated Show resolved Hide resolved

Update .github/workflows/build_native.yml

90f458f

Co-authored-by: JJ Kasper <jj@jjsweb.site>

Build next-swc binaries

c1c63cd

kdy1 changed the title ~~Improve CI time~~ Update swc & Improve CI time Oct 13, 2021

timneutkens merged commit bf9e998 into vercel:canary Oct 13, 2021

timneutkens deleted the ci-time branch October 13, 2021 16:55

kara mentioned this pull request Oct 13, 2021

Refactor Document to prep for classic streaming #29834

Merged

ijjk added the hacktoberfest-accepted label Oct 14, 2021

ijjk mentioned this pull request Oct 14, 2021

Add native build caching to main workflow also #29920

Merged

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

kdy1 self-assigned this Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update swc & Improve CI time #29884

Update swc & Improve CI time #29884

kdy1 commented Oct 13, 2021

sokra Oct 13, 2021

kdy1 Oct 13, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 13, 2021

This comment has been minimized.

ijjk commented Oct 13, 2021

Update swc & Improve CI time #29884

Update swc & Improve CI time #29884

Conversation

kdy1 commented Oct 13, 2021

Bug

Feature

Documentation / Examples

sokra Oct 13, 2021

Choose a reason for hiding this comment

kdy1 Oct 13, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 13, 2021

Failing test suites

This comment has been minimized.

ijjk commented Oct 13, 2021

Stats from current PR