Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect feature usage for optimizeCss #29828

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

kyliau
Copy link

@kyliau kyliau commented Oct 11, 2021

optimizeCss is a feature that inlines critical CSS using critters.
The Aurora team would like to gauge adoption rate for this feature.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@kyliau
Copy link
Author

kyliau commented Oct 11, 2021

cc: @janicklas-ralph FYI

@ijjk

This comment has been minimized.

`optimizeCss` is a feature that inlines critical CSS using critters.
The Aurora team would like to gauge adoption rate for this feature.
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 11, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kyliau/next.js optimize-css Change
buildDuration 12.5s 12.5s -9ms
buildDurationCached 2.9s 2.8s -157ms
nodeModulesSize 195 MB 195 MB ⚠️ +901 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kyliau/next.js optimize-css Change
/ failed reqs 0 0
/ total time (seconds) 2.773 2.811 ⚠️ +0.04
/ avg req/sec 901.49 889.4 ⚠️ -12.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.298 1.346 ⚠️ +0.05
/error-in-render avg req/sec 1925.97 1857.78 ⚠️ -68.19
Client Bundles (main, webpack, commons)
vercel/next.js canary kyliau/next.js optimize-css Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.9 kB 70.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kyliau/next.js optimize-css Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kyliau/next.js optimize-css Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary kyliau/next.js optimize-css Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary kyliau/next.js optimize-css Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kyliau/next.js optimize-css Change
buildDuration 5.8s 6.3s ⚠️ +447ms
buildDurationCached 3.1s 2.9s -199ms
nodeModulesSize 195 MB 195 MB ⚠️ +901 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kyliau/next.js optimize-css Change
/ failed reqs 0 0
/ total time (seconds) 2.764 2.829 ⚠️ +0.07
/ avg req/sec 904.64 883.8 ⚠️ -20.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.329 1.337 ⚠️ +0.01
/error-in-render avg req/sec 1880.61 1869.35 ⚠️ -11.26
Client Bundles (main, webpack, commons)
vercel/next.js canary kyliau/next.js optimize-css Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 35 kB 35 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kyliau/next.js optimize-css Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kyliau/next.js optimize-css Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary kyliau/next.js optimize-css Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary kyliau/next.js optimize-css Change
index.html gzip 537 B 537 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: d1a62e4

@kodiakhq kodiakhq bot merged commit 13f68de into vercel:canary Oct 11, 2021
@kyliau kyliau deleted the optimize-css branch October 12, 2021 17:22
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants