Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using absolute paths in import/require #29797

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 11, 2021

Using absolute paths leads to unnecessary watched paths and tested paths for resolving

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 11, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
buildDuration 12.1s 12.2s ⚠️ +118ms
buildDurationCached 3s 3.2s ⚠️ +127ms
nodeModulesSize 195 MB 195 MB ⚠️ +1.34 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
/ failed reqs 0 0
/ total time (seconds) 2.704 2.736 ⚠️ +0.03
/ avg req/sec 924.7 913.63 ⚠️ -11.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.239 1.283 ⚠️ +0.04
/error-in-render avg req/sec 2017.91 1948.32 ⚠️ -69.59
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.9 kB 26.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
buildDuration 6.1s 6s -67ms
buildDurationCached 2.9s 2.8s -26ms
nodeModulesSize 195 MB 195 MB ⚠️ +1.34 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
/ failed reqs 0 0
/ total time (seconds) 2.735 2.731 0
/ avg req/sec 914.03 915.45 +1.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.29 1.284 -0.01
/error-in-render avg req/sec 1937.4 1946.96 +9.56
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 35 kB 35 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/avoid-absolute Change
index.html gzip 538 B 538 B
link.html gzip 553 B 553 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 9deeb61

@kodiakhq kodiakhq bot merged commit 87d0fc9 into canary Oct 11, 2021
@kodiakhq kodiakhq bot deleted the bugfix/avoid-absolute branch October 11, 2021 08:53
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants