Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint.md with instructions for installing Prettier plugin dependency #29764

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Update eslint.md with instructions for installing Prettier plugin dependency #29764

merged 5 commits into from
Oct 18, 2021

Conversation

TimBarley
Copy link
Contributor

Added install instructions for eslint-config-prettier before adding Prettier to the ESLint config.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

molebox
molebox previously approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks-good

leerob
leerob reviewed Oct 12, 2021
View reviewed changes
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
leerob
leerob previously approved these changes Oct 12, 2021
View reviewed changes
housseindjirdeh
housseindjirdeh approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

LGTM!

@kodiakhq kodiakhq bot merged commit b794c17 into vercel:canary Oct 18, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

@styfle styfle styfle approved these changes

@molebox molebox molebox left review comments

@leerob leerob leerob left review comments

@huozhi huozhi Awaiting requested review from huozhi

@lfades lfades Awaiting requested review from lfades

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TimBarley @styfle @leerob @housseindjirdeh @ijjk @molebox