Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to latest strip-ansi #29715

Closed
wants to merge 2 commits into from
Closed

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 7, 2021

This updates to latest strip-ansi to remove a false vulnerability warning some users are seeing.

x-ref: #29429 (reply in thread)

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 7, 2021
@ijjk
Copy link
Member Author

ijjk commented Oct 7, 2021

Failing test suites

Commit: df5a638

test/integration/404-page-custom-error/test/index.test.js

  • Default 404 Page with custom _error > dev mode > should render error correctly
Expand output

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "Internal Server Error"

  31 |   it('should render error correctly', async () => {
  32 |     const text = await renderViaHTTP(appPort, '/err')
> 33 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  34 |   })
  35 |
  36 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:33:18)

test/integration/404-page-ssg/test/index.test.js

  • 404 Page Support SSG > dev mode > should render error correctly
Expand output

● 404 Page Support SSG › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "Internal Server Error"

  34 |   it('should render error correctly', async () => {
  35 |     const text = await renderViaHTTP(appPort, '/err')
> 36 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  37 |   })
  38 |
  39 |   it('should not show an error in the logs for 404 SSG', async () => {

  at Object.<anonymous> (integration/404-page-ssg/test/index.test.js:36:18)

test/integration/catches-missing-getStaticProps/test/index.test.js

  • Catches Missing getStaticProps > should catch it in dev mode
Expand output

● Catches Missing getStaticProps › should catch it in dev mode

expect(received).toMatch(expected)

Expected pattern: /getStaticPaths was added without a getStaticProps in/
Received string:  "Internal Server Error"

  24 |     await killApp(app)
  25 |
> 26 |     expect(html).toMatch(errorRegex)
     |                  ^
  27 |   })
  28 |
  29 |   it('should catch it in server build mode', async () => {

  at Object.<anonymous> (integration/catches-missing-getStaticProps/test/index.test.js:26:18)

test/integration/conflicting-public-file-page/test/index.test.js

  • Errors on conflict between public file and page file > Throws error during development
Expand output

● Errors on conflict between public file and page file › Throws error during development

expect(received).toMatch(expected)

Expected pattern: /A conflicting public file and page file was found for path/
Received string:  "Internal Server Error"

  20 |     for (const conflict of conflicts) {
  21 |       const html = await renderViaHTTP(appPort, conflict)
> 22 |       expect(html).toMatch(
     |                    ^
  23 |         /A conflicting public file and page file was found for path/
  24 |       )
  25 |     }

  at Object.<anonymous> (integration/conflicting-public-file-page/test/index.test.js:22:20)

@ijjk ijjk closed this Oct 7, 2021
@ijjk ijjk deleted the update/strip-ansi branch October 7, 2021 19:34
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant