Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update swc #29675

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Chore/update swc #29675

merged 2 commits into from
Oct 6, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Oct 6, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@styfle styfle changed the title Chore/udate swc Chore/update swc Oct 6, 2021
@ijjk
Copy link
Member

ijjk commented Oct 6, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/udate-swc Change
buildDuration 11.6s 11.6s ⚠️ +11ms
buildDurationCached 3.1s 2.8s -344ms
nodeModulesSize 194 MB 194 MB ⚠️ +285 kB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js chore/udate-swc Change
/ failed reqs 0 0
/ total time (seconds) 2.683 2.623 -0.06
/ avg req/sec 931.63 953.11 +21.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.219 1.206 -0.01
/error-in-render avg req/sec 2050.21 2072.18 +21.97
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/udate-swc Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.9 kB 26.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/udate-swc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/udate-swc Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/udate-swc Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/udate-swc Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/udate-swc Change
buildDuration 5.9s 5.9s -18ms
buildDurationCached 2.7s 2.8s ⚠️ +63ms
nodeModulesSize 194 MB 194 MB ⚠️ +285 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/udate-swc Change
/ failed reqs 0 0
/ total time (seconds) 2.572 2.518 -0.05
/ avg req/sec 972.03 992.71 +20.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.247 1.262 ⚠️ +0.01
/error-in-render avg req/sec 2004.03 1981.5 ⚠️ -22.53
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/udate-swc Change
675-HASH.js gzip 13.8 kB 13.8 kB ⚠️ +1 B
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 35 kB ⚠️ +29 B
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB ⚠️ +30 B
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/udate-swc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/udate-swc Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB -1 B
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 557 B 557 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.22 kB ⚠️ +21 B
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB ⚠️ +20 B
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/udate-swc Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/udate-swc Change
index.html gzip 537 B 539 B ⚠️ +2 B
link.html gzip 550 B 552 B ⚠️ +2 B
withRouter.html gzip 530 B 533 B ⚠️ +3 B
Overall change 1.62 kB 1.62 kB ⚠️ +7 B
Commit: f92080d

@ijjk
Copy link
Member

ijjk commented Oct 6, 2021

Failing test suites

Commit: f92080d

test/development/basic/hmr.test.ts

  • basic HMR > Error Recovery > should recover after exporting an invalid page
  • basic HMR > Error Recovery > should recover after a bad return from the render function
  • basic HMR > Error Recovery > should recover after undefined exported as default
Expand output

● basic HMR › Error Recovery › should recover after exporting an invalid page

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:510:9)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:558:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after undefined exported as default 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about7"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  600 |         await next.patchFile(aboutPage, aboutContent)
  601 |
> 602 |         if (browser) {
      |                       ^
  603 |           await check(
  604 |             () => getBrowserBodyText(browser),
  605 |             /This is the about page/

  at Object.<anonymous> (development/basic/hmr.test.ts:602:23)

@padmaia padmaia merged commit d1308b8 into vercel:canary Oct 6, 2021
@padmaia padmaia deleted the chore/udate-swc branch October 6, 2021 17:16
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants