Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples/cms-contentful #29641

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Update examples/cms-contentful #29641

merged 4 commits into from
Oct 5, 2021

Conversation

whitep4nth3r
Copy link
Contributor

@whitep4nth3r whitep4nth3r commented Oct 5, 2021 •
edited
Loading

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 5, 2021
leerob
leerob approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🥳

@leerob
Copy link
Member

leerob commented Oct 5, 2021

Also: You're now a contributor to Next.js! 🏎️

@ijjk ijjk merged commit 9d28142 into vercel:canary Oct 5, 2021
@whitep4nth3r whitep4nth3r deleted the update-example-cms-contentful branch October 6, 2021 08:02
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob leerob approved these changes

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whitep4nth3r @leerob @ijjk