Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all package.json files are traced correctly #29539

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 1, 2021

This fixes cases where not all package.jsons were being added to the traces correctly while using webpack's resolving with the outputFileTracing. The specific case notice while testing has been added as an integration test to ensure it is working as expected.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 1, 2021
@ijjk
Copy link
Member Author

ijjk commented Oct 1, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
buildDuration 12.1s 12.1s ⚠️ +4ms
buildDurationCached 3.4s 3.1s -263ms
nodeModulesSize 183 MB 183 MB ⚠️ +3.49 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
/ failed reqs 0 0
/ total time (seconds) 2.699 2.696 0
/ avg req/sec 926.41 927.46 +1.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.282 1.279 0
/error-in-render avg req/sec 1949.51 1954.53 +5.02
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
buildDuration 6.5s 6.3s -139ms
buildDurationCached 3.1s 3.1s ⚠️ +20ms
nodeModulesSize 183 MB 183 MB ⚠️ +3.49 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
/ failed reqs 0 0
/ total time (seconds) 2.707 2.724 ⚠️ +0.02
/ avg req/sec 923.43 917.9 ⚠️ -5.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.278 1.308 ⚠️ +0.03
/error-in-render avg req/sec 1956.59 1911.14 ⚠️ -45.45
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 35 kB 35 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/trace-resolve-pjson Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: d9385b3

@ijjk ijjk marked this pull request as ready for review October 1, 2021 05:50
@kodiakhq kodiakhq bot merged commit 458e34d into vercel:canary Oct 1, 2021
@ijjk ijjk deleted the fix/trace-resolve-pjson branch October 1, 2021 15:22
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants