Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update webpack #29469

Merged
merged 1 commit into from
Sep 29, 2021
Merged

update webpack #29469

merged 1 commit into from
Sep 29, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 28, 2021 •
edited
Loading

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Sep 28, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Sep 29, 2021

Failing test suites

Commit: 4054dfd

test/integration/app-document-remove-hmr/test/index.test.js

  • _app removal HMR > should HMR when _document is removed
Expand output

● _app removal HMR › should HMR when _document is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1632907169819"></script><script src="/_next/static/chunks/webpack.js?ts=1632907169819" defer=""></script><script src="/_next/static/chunks/main.js?ts=1632907169819" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1632907169819" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1632907169819" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1632907169819" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1632907169819" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>custom _app</p><p>index page</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1632907169819"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:123:7)

@ijjk
Copy link
Member

ijjk commented Sep 29, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 14.3s 14.2s -25ms
buildDurationCached 3.8s 3.4s -384ms
nodeModulesSize 181 MB 181 MB ⚠️ +10.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.37 3.426 ⚠️ +0.06
/ avg req/sec 741.94 729.78 ⚠️ -12.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.732 1.719 -0.01
/error-in-render avg req/sec 1443.05 1454.59 +11.54
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
779.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27 kB 27 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.8 kB 70.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 977 B 977 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 328 B 328 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.15 kB 4.15 kB ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 494 B 494 B ✓
Overall change 494 B 494 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 539 B 539 B ✓
link.html gzip 551 B 551 B ✓
withRouter.html gzip 533 B 533 B ✓
Overall change 1.62 kB 1.62 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 7.3s 7.4s ⚠️ +104ms
buildDurationCached 3.5s 4s ⚠️ +493ms
nodeModulesSize 181 MB 181 MB ⚠️ +10.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.288 3.381 ⚠️ +0.09
/ avg req/sec 760.23 739.36 ⚠️ -20.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.762 1.742 -0.02
/error-in-render avg req/sec 1418.46 1434.89 +16.43
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
675-HASH.js gzip 13.8 kB 13.8 kB ✓
770.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 50.7 kB 50.7 kB ✓
main-HASH.js gzip 34.9 kB 34.9 kB ✓
webpack-HASH.js gzip 1.64 kB 1.64 kB ✓
Overall change 101 kB 101 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 1.33 kB 1.33 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 315 B 315 B ✓
css-HASH.js gzip 331 B 331 B ✓
dynamic-HASH.js gzip 2.79 kB 2.79 kB ✓
head-HASH.js gzip 356 B 356 B ✓
hooks-HASH.js gzip 637 B 637 B ✓
image-HASH.js gzip 573 B 573 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 2.2 kB 2.2 kB ✓
routerDirect..HASH.js gzip 326 B 326 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 322 B 322 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 512 B 512 B ✓
Overall change 512 B 512 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 539 B 539 B ✓
link.html gzip 551 B 551 B ✓
withRouter.html gzip 531 B 531 B ✓
Overall change 1.62 kB 1.62 kB ✓
Commit: 4054dfd

@sokra
Copy link
Member Author

sokra commented Sep 29, 2021

test/integration/app-document-remove-hmr/test/index.test.js

  • _app removal HMR > should HMR when _document is removed

That flake also exists on canary. It's not caused by that PR.

@sokra sokra marked this pull request as ready for review September 29, 2021 10:14
@timneutkens timneutkens merged commit 6f89d8f into canary Sep 29, 2021
@timneutkens timneutkens deleted the webpack/upgrade branch September 29, 2021 10:29
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @timneutkens