Rename `onReadyToStream` to `onCompleteShell` #29442

devknoll · 2021-09-27T20:17:16Z

Updates to the newest API (see: facebook/react#22443)

ijjk · 2021-09-28T19:23:11Z

Failing test suites

Commit: ab773fd

test/integration/app-document-remove-hmr/test/index.test.js

_app removal HMR > should HMR when _document is removed

Expand output

● _app removal HMR › should HMR when _document is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1632856954715"></script><script src="/_next/static/chunks/webpack.js?ts=1632856954715" defer=""></script><script src="/_next/static/chunks/main.js?ts=1632856954715" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1632856954715" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1632856954715" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1632856954715" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1632856954715" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>custom _app</p><p>index page</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1632856954715"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:123:7)

ijjk · 2021-09-28T19:28:16Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
buildDuration	15.7s	16s	⚠️ +250ms
buildDurationCached	4s	4.2s	⚠️ +120ms
nodeModulesSize	181 MB	181 MB	⚠️ +1 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.652	3.638	-0.01
/ avg req/sec	684.51	687.18	+2.67
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.04	2.059	⚠️ +0.02
/error-in-render avg req/sec	1225.65	1214.27	⚠️ -11.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.8 kB	70.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.15 kB	4.15 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
_buildManifest.js gzip	494 B	494 B	✓
Overall change	494 B	494 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
index.html gzip	539 B	539 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
buildDuration	8.5s	8.4s	-60ms
buildDurationCached	4s	4.1s	⚠️ +98ms
nodeModulesSize	181 MB	181 MB	⚠️ +1 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.697	3.7	0
/ avg req/sec	676.28	675.66	⚠️ -0.62
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.108	1.942	-0.17
/error-in-render avg req/sec	1186.23	1287.05	+100.82

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	34.9 kB	34.9 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	356 B	356 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	573 B	573 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	2.2 kB	2.2 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
_buildManifest.js gzip	512 B	512 B	✓
Overall change	512 B	512 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js x-rename-on-ready-to-stream	Change
index.html gzip	539 B	539 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	531 B	531 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: ab773fd

ijjk added created-by: Chrome Aurora type: next labels Sep 27, 2021

This comment has been minimized.

Sign in to view

Rename onReadyToStream -> onCompleteShell

a793b55

devknoll force-pushed the x-rename-on-ready-to-stream branch from 1d8666f to a793b55 Compare September 28, 2021 16:43

This comment has been minimized.

Sign in to view

Merge branch 'canary' into x-rename-on-ready-to-stream

47512f2

This comment has been minimized.

Sign in to view

Merge branch 'canary' into x-rename-on-ready-to-stream

ab773fd

devknoll marked this pull request as ready for review September 28, 2021 19:13

devknoll requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners September 28, 2021 19:13

ijjk approved these changes Sep 28, 2021

View reviewed changes

shuding approved these changes Sep 28, 2021

View reviewed changes

ijjk merged commit 0f1a4fa into vercel:canary Sep 28, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `onReadyToStream` to `onCompleteShell` #29442

Rename `onReadyToStream` to `onCompleteShell` #29442

devknoll commented Sep 27, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Sep 28, 2021

ijjk commented Sep 28, 2021

Rename onReadyToStream to onCompleteShell #29442

Rename onReadyToStream to onCompleteShell #29442

Conversation

devknoll commented Sep 27, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Sep 28, 2021

Failing test suites

ijjk commented Sep 28, 2021

Stats from current PR

Rename `onReadyToStream` to `onCompleteShell` #29442

Rename `onReadyToStream` to `onCompleteShell` #29442

devknoll commented Sep 27, 2021 •

edited

Loading