Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add-entry span duration #29288

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

timneutkens
Copy link
Member

Currently the span is finished on seal but that's not the actual timing where the entry span is finished as there's a succeedEntry hook. This PR changes the span to finish on succeedEntry.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 22, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
buildDuration 17s 17s ⚠️ +82ms
buildDurationCached 4.3s 4.3s -25ms
nodeModulesSize 182 MB 182 MB ⚠️ +641 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
/ failed reqs 0 0
/ total time (seconds) 3.833 3.827 -0.01
/ avg req/sec 652.31 653.2 +0.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.177 2.123 -0.05
/error-in-render avg req/sec 1148.54 1177.65 +29.11
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.8 kB 26.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.6 kB 70.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
buildDuration 8.5s 8.4s -115ms
buildDurationCached 4.2s 4.3s ⚠️ +26ms
nodeModulesSize 182 MB 182 MB ⚠️ +641 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
/ failed reqs 0 0
/ total time (seconds) 3.674 3.74 ⚠️ +0.07
/ avg req/sec 680.4 668.5 ⚠️ -11.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.098 2.078 -0.02
/error-in-render avg req/sec 1191.61 1203 +11.39
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.7 kB 34.7 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/add-entry-span Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: c53030f

@kodiakhq kodiakhq bot merged commit 0d4e4e9 into vercel:canary Sep 22, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants