Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename experimental tracing to outputFileTracing #29267

Merged
merged 6 commits into from
Sep 21, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 21, 2021

Renaming this prop for clarity before we move this out of experimental

@ijjk

This comment has been minimized.

@styfle styfle requested a review from ijjk September 21, 2021 17:08
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 21, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
buildDuration 14.4s 14.4s -24ms
buildDurationCached 3.8s 3.7s -56ms
nodeModulesSize 181 MB 181 MB ⚠️ +689 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
/ failed reqs 0 0
/ total time (seconds) 3.15 3.063 -0.09
/ avg req/sec 793.71 816.24 +22.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.553 1.47 -0.08
/error-in-render avg req/sec 1609.73 1700.53 +90.8
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.8 kB 26.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.6 kB 70.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
buildDuration 7.3s 7.4s ⚠️ +135ms
buildDurationCached 3.7s 3.7s -89ms
nodeModulesSize 181 MB 181 MB ⚠️ +689 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
/ failed reqs 0 0
/ total time (seconds) 3.066 3.033 -0.03
/ avg req/sec 815.4 824.23 +8.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.493 1.478 -0.02
/error-in-render avg req/sec 1674.33 1691.3 +16.97
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.7 kB 34.7 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js rename-nfttracing-to-outputfiletracing Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 6438e1d

@kodiakhq kodiakhq bot merged commit 9c86953 into canary Sep 21, 2021
@kodiakhq kodiakhq bot deleted the rename-nfttracing-to-outputfiletracing branch September 21, 2021 22:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants