-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transform of ` in styled-jsx #29136
Conversation
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
buildDuration | 12.5s | 12.2s | -300ms |
buildDurationCached | 3.1s | 3s | -175ms |
nodeModulesSize | 182 MB | 182 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.636 | 2.352 | -0.28 |
/ avg req/sec | 948.26 | 1062.76 | +114.5 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.317 | 1.27 | -0.05 |
/error-in-render avg req/sec | 1898.87 | 1968.33 | +69.46 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 26.6 kB | 26.6 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.4 kB | 70.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
buildDuration | 6.1s | 6.2s | |
buildDurationCached | 3.1s | 3s | -28ms |
nodeModulesSize | 182 MB | 182 MB | ✓ |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.525 | 2.568 | |
/ avg req/sec | 990.16 | 973.45 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.29 | 1.3 | |
/error-in-render avg req/sec | 1938.34 | 1923.19 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
264.HASH.js gzip | 179 B | 179 B | ✓ |
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
main-HASH.js gzip | 34.4 kB | 34.4 kB | ✓ |
webpack-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error-HASH.js gzip | 179 B | 179 B | ✓ |
amp-HASH.js gzip | 331 B | 331 B | ✓ |
css-HASH.js gzip | 352 B | 352 B | ✓ |
dynamic-HASH.js gzip | 2.8 kB | 2.8 kB | ✓ |
head-HASH.js gzip | 356 B | 356 B | ✓ |
hooks-HASH.js gzip | 652 B | 652 B | ✓ |
image-HASH.js gzip | 575 B | 575 B | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
routerDirect..HASH.js gzip | 327 B | 327 B | ✓ |
script-HASH.js gzip | 392 B | 392 B | ✓ |
withRouter-HASH.js gzip | 323 B | 323 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.2 kB | 10.2 kB | ✓ |
Client Build Manifests
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
_buildManifest.js gzip | 515 B | 515 B | ✓ |
Overall change | 515 B | 515 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | kdy1/next.js codegen-ver | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 552 B | 552 B | ✓ |
withRouter.html gzip | 531 B | 531 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
external_hash: Option<String>, | ||
add_hash: Option<(String, String)>, | ||
add_default_decl: Option<(String, Expr)>, | ||
evaluator: Option<Evaluator>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these whitespace changes intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a result of rustfmt
.
I'm not sure, but running rustfmt
for all files by doing cargo fmt
on commit may worth it.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples