Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure browser instances are not re-created un-necessarily #29091

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Ensure browser instances are not re-created un-necessarily #29091

merged 5 commits into from
Sep 15, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 14, 2021 •
edited
Loading

This fixes re-launching the playwright browser at the start of each webdriver call un-necessarily by ensuring we re-use the instance already created.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Sep 14, 2021
@ijjk ijjk marked this pull request as ready for review September 14, 2021 19:34
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Sep 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
buildDuration 11.4s 11.7s ⚠️ +246ms
buildDurationCached 2.9s 2.9s -12ms
nodeModulesSize 182 MB 182 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.357 2.555 ⚠️ +0.2
/ avg req/sec 1060.64 978.53 ⚠️ -82.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.161 1.167 ⚠️ +0.01
/error-in-render avg req/sec 2152.99 2141.78 ⚠️ -11.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 26.6 kB 26.6 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.4 kB 70.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
_app-HASH.js gzip 979 B 979 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.14 kB 4.14 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 318 B 318 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
_buildManifest.js gzip 492 B 492 B ✓
Overall change 492 B 492 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
index.html gzip 540 B 540 B ✓
link.html gzip 552 B 552 B ✓
withRouter.html gzip 534 B 534 B ✓
Overall change 1.63 kB 1.63 kB ✓
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
buildDuration 5.9s 5.8s -62ms
buildDurationCached 2.8s 2.8s ⚠️ +1ms
nodeModulesSize 182 MB 182 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.355 2.475 ⚠️ +0.12
/ avg req/sec 1061.54 1010.23 ⚠️ -51.31
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.202 1.22 ⚠️ +0.02
/error-in-render avg req/sec 2080.1 2049.09 ⚠️ -31.01
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
264.HASH.js gzip 179 B 179 B ✓
675-HASH.js gzip 13.8 kB 13.8 kB ✓
framework-HASH.js gzip 50.7 kB 50.7 kB ✓
main-HASH.js gzip 34.4 kB 34.4 kB ✓
webpack-HASH.js gzip 1.65 kB 1.65 kB ✓
Overall change 101 kB 101 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
_app-HASH.js gzip 1.33 kB 1.33 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 331 B 331 B ✓
css-HASH.js gzip 352 B 352 B ✓
dynamic-HASH.js gzip 2.8 kB 2.8 kB ✓
head-HASH.js gzip 356 B 356 B ✓
hooks-HASH.js gzip 652 B 652 B ✓
image-HASH.js gzip 575 B 575 B ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.2 kB 2.2 kB ✓
routerDirect..HASH.js gzip 327 B 327 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 323 B 323 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 10.2 kB 10.2 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
_buildManifest.js gzip 515 B 515 B ✓
Overall change 515 B 515 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/playwright-instances Change
index.html gzip 538 B 538 B ✓
link.html gzip 551 B 551 B ✓
withRouter.html gzip 530 B 530 B ✓
Overall change 1.62 kB 1.62 kB ✓
Commit: ba87059

@ijjk ijjk merged commit 6a9cda5 into vercel:canary Sep 15, 2021
@ijjk ijjk deleted the fix/playwright-instances branch September 15, 2021 15:03
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 16, 2021
Merge branch 'canary' into feature/symlink-pages
f24eaac 
* canary: (41 commits)
  Add client-side debugging instructions (vercel#28815)
  v11.1.3-canary.19
  Update next-swc binaries (vercel#29132)
  Fix partial one off global selectors (vercel#29128)
  Update trace ignores for next import (vercel#29119)
  Development tracing improvements (vercel#29076)
  Remove log from failing to parse source map (vercel#29118)
  Remove inert font tag in font optimization (vercel#28869)
  v11.1.3-canary.18
  Update Redux example to use Toolkit + update dependencies. (vercel#29104)
  Ensure browser instances are not re-created un-necessarily (vercel#29091)
  Update styled-jsx (vercel#29103)
  v11.1.3-canary.17
  Add/styled jsx swc (vercel#29005)
  v11.1.3-canary.16
  Fix host segment replacing for custom routes (vercel#29090)
  Add stats config for SWC (vercel#28883)
  reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074)
  Add crossOrigin type to the NextConfig (vercel#29033)
  Fix/upload binary artifact (vercel#29069)
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle