Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Updates with-google-tag-manager example to use <Script> component #29061

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[Examples] Updates with-google-tag-manager example to use <Script> component #29061

merged 2 commits into from
Sep 13, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Sep 13, 2021 •
edited by ijjk
Loading

Updates the with-google-tag-manager to use Next.js' Script component with strategy set to afterInteractive

CC @janicklas-ralph

Closes: #26507

@ijjk ijjk added created-by: Chrome Aurora examples Issue was opened via the examples template. labels Sep 13, 2021
@matamatanot
Copy link
Contributor

close #26507

@kodiakhq kodiakhq bot merged commit 01d3539 into vercel:canary Sep 13, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@janicklas-ralph janicklas-ralph janicklas-ralph approved these changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[with-google-analytics] Should Use next/script component
4 participants
@housseindjirdeh @matamatanot @janicklas-ralph @ijjk