[ESLint] Add add next/script support for no-unwanted-polyfillio rule

[ka2n]

Make the no-unwanted-polyfillio rule respond to the next/script component as well as the script tag.

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• IntegrationUnit tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

[housseindjirdeh]

This is great, thank you! Just minor nits about adding additional checks in the case of undefined properties.

[ka2n]

@hussainanjar Thanks for the review! I've taken your suggestion into commit.

[styfle]

Thanks!

[ijjk]

Failing test suites

Commit: 2a6ebae

test/development/basic-basepath/hmr.test.ts

• basic HMR > Error Recovery > should recover after exporting an invalid page
• basic HMR > Error Recovery > should recover after a bad return from the render function
• basic HMR > Error Recovery > should recover after undefined exported as default

Expand output

● basic HMR › Error Recovery › should recover after exporting an invalid page

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after exporting an invalid page 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about5"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  491 |
  492 |         expect(await hasRedbox(browser)).toBe(true)
> 493 |         expect(await getRedboxHeader(browser)).toMatchInlineSnapshot(`
      |                                                ^
  494 |           " 1 of 1 unhandled error
  495 |           Server Error
  496 |

  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:493:48)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:561:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after undefined exported as default 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about7"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  603 |         await next.patchFile(aboutPage, aboutContent)
  604 |
> 605 |         if (browser) {
      |                       ^
  606 |           await check(
  607 |             () => getBrowserBodyText(browser),
  608 |             /This is the about page/

  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:605:23)

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
buildDuration	18s	17.1s	-892ms
buildDurationCached	3.8s	3.8s	-14ms
nodeModulesSize	196 MB	196 MB	⚠️ +1 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.103	4.153	⚠️ +0.05
/ avg req/sec	609.34	602.02	⚠️ -7.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.329	2.379	⚠️ +0.05
/error-in-render avg req/sec	1073.6	1050.76	⚠️ -22.84

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
651.cd440d20..0b23.js gzip	2.96 kB	2.96 kB	✓
831.695e33f6..205f.js gzip	179 B	179 B	✓
framework-89..a097.js gzip	42.2 kB	42.2 kB	✓
main-6c9ec8a..39ec.js gzip	26.1 kB	26.1 kB	✓
webpack-f09b..493e.js gzip	1.47 kB	1.47 kB	✓
Overall change	73 kB	73 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
_app-9fb8765..c13d.js gzip	979 B	979 B	✓
_error-d828d..2954.js gzip	3.06 kB	3.06 kB	✓
amp-5388d1f5..4ce9.js gzip	551 B	551 B	✓
css-10424225..367a.js gzip	329 B	329 B	✓
dynamic-9821..3cd4.js gzip	2.67 kB	2.67 kB	✓
head-1df323b..d261.js gzip	2.32 kB	2.32 kB	✓
hooks-ab0016..b093.js gzip	917 B	917 B	✓
image-c3cc30..4e2a.js gzip	5.87 kB	5.87 kB	✓
index-95c8cb..6970.js gzip	260 B	260 B	✓
link-05c99e7..35ec.js gzip	1.66 kB	1.66 kB	✓
routerDirect..6659.js gzip	319 B	319 B	✓
script-d94ba..ed05.js gzip	386 B	386 B	✓
withRouter-7..8b2e.js gzip	317 B	317 B	✓
9a34b27eb3f9..27d.css gzip	125 B	125 B	✓
Overall change	19.8 kB	19.8 kB	✓

Client Build Manifests

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
index.html gzip	536 B	536 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
buildDuration	8.1s	8.1s	-46ms
buildDurationCached	3.7s	3.6s	-89ms
nodeModulesSize	196 MB	196 MB	⚠️ +1 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.174	4.152	-0.02
/ avg req/sec	598.93	602.16	+3.23
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.254	2.249	0
/error-in-render avg req/sec	1109.19	1111.37	+2.18

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
450.fd3ad245..022b.js gzip	179 B	179 B	✓
675-228d3e2f..0c27.js gzip	13.8 kB	13.8 kB	✓
framework-13..70b0.js gzip	50.8 kB	50.8 kB	✓
main-24da2a3..cbb3.js gzip	36.5 kB	36.5 kB	✓
webpack-a7f2..2650.js gzip	1.63 kB	1.63 kB	✓
Overall change	103 kB	103 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
_app-ae91bc3..d985.js gzip	1.33 kB	1.33 kB	✓
_error-273ac..9ef0.js gzip	180 B	180 B	✓
amp-5f9a7694..99ce.js gzip	315 B	315 B	✓
css-3a1b2477..df1e.js gzip	330 B	330 B	✓
dynamic-e04a..a1b5.js gzip	2.79 kB	2.79 kB	✓
head-7f600d0..daa3.js gzip	356 B	356 B	✓
hooks-bd8c02..0730.js gzip	638 B	638 B	✓
image-16df09..4584.js gzip	555 B	555 B	✓
index-80be94..e89f.js gzip	262 B	262 B	✓
link-4ee1ea7..8745.js gzip	2.22 kB	2.22 kB	✓
routerDirect..c4aa.js gzip	325 B	325 B	✓
script-67da0..49e6.js gzip	390 B	390 B	✓
withRouter-2..2409.js gzip	322 B	322 B	✓
9a34b27eb3f9..27d.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
_buildManifest.js gzip	477 B	477 B	✓
Overall change	477 B	477 B	✓

Rendered Page Sizes

	vercel/next.js canary	ka2n/next.js eslint-support-nextscript	Change
index.html gzip	535 B	535 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	529 B	529 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: feb3fe1