Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github labeler with eslint-plugin-next #28751

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 2, 2021

The eslint-plugin-next package should be considered a "core" package since it powers the next lint command

The `eslint-plugin-next` pacakge should be considered a "core" package since it powers the `next lint` command
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Sep 2, 2021
.github/labeler.json Outdated Show resolved Hide resolved
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@styfle styfle requested a review from ijjk September 2, 2021 23:26
@ijjk
Copy link
Member

ijjk commented Sep 2, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
buildDuration 10.8s 10.9s ⚠️ +136ms
buildDurationCached 2.8s 2.8s -18ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
/ failed reqs 0 0
/ total time (seconds) 2.082 2.135 ⚠️ +0.05
/ avg req/sec 1200.94 1170.7 ⚠️ -30.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.164 1.2 ⚠️ +0.04
/error-in-render avg req/sec 2147.94 2083.85 ⚠️ -64.09
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
index.html gzip 541 B 541 B
link.html gzip 553 B 553 B
withRouter.html gzip 533 B 533 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
buildDuration 8.9s 9.4s ⚠️ +517ms
buildDurationCached 3.7s 3.7s ⚠️ +18ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
/ failed reqs 0 0
/ total time (seconds) 2.115 2.255 ⚠️ +0.14
/ avg req/sec 1182.19 1108.5 ⚠️ -73.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.177 1.282 ⚠️ +0.1
/error-in-render avg req/sec 2124.52 1950.74 ⚠️ -173.78
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-next-lint-to-core Change
index.html gzip 584 B 584 B
link.html gzip 596 B 596 B
withRouter.html gzip 577 B 577 B
Overall change 1.76 kB 1.76 kB
Commit: ded5ff2

@kodiakhq kodiakhq bot merged commit fcdf732 into canary Sep 3, 2021
@kodiakhq kodiakhq bot deleted the add-next-lint-to-core branch September 3, 2021 03:45
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants