Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router-is-ready test. Clean up unused vars. #28723

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

andersonleite
Copy link
Contributor

Variable isDev is not used in both tests.
The tests run dev/prod modes based on the different test scenarios.

Bug

  • Integration tests clean up

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Sep 2, 2021

Stats from current PR

Default Build
General
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
buildDuration 10.7s 10.7s -45ms
buildDurationCached 2.7s 2.7s -55ms
nodeModulesSize 50.4 MB 50.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
/ failed reqs 0 0
/ total time (seconds) 2.067 2.079 ⚠️ +0.01
/ avg req/sec 1209.58 1202.35 ⚠️ -7.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.139 1.135 0
/error-in-render avg req/sec 2195.56 2203.07 +7.51
Client Bundles (main, webpack, commons)
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
buildDuration 8.7s 8.8s ⚠️ +36ms
buildDurationCached 3.7s 3.8s ⚠️ +53ms
nodeModulesSize 50.4 MB 50.4 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
/ failed reqs 0 0
/ total time (seconds) 2.082 2.057 -0.02
/ avg req/sec 1200.59 1215.46 +14.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.166 1.175 ⚠️ +0.01
/error-in-render avg req/sec 2143.23 2128.01 ⚠️ -15.22
Client Bundles (main, webpack, commons)
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary andersonleite/next.js test-router-is-ready Change
index.html gzip 585 B 585 B
link.html gzip 596 B 596 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: f95f7f5

@kodiakhq kodiakhq bot merged commit e00b946 into vercel:canary Sep 2, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants