Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test set-up to leverage playwright when able to #28634

Merged
merged 71 commits into from
Sep 13, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 31, 2021

This updates our next-webdriver test util to allow leveraging selenium or playwright for testing so that we can leverage playwright without having to drop testing IE11 and older safari versions. By default playwright with chromium will be used so that contributors don't need to worry about having chrome and the matching chromedriver version installed to run the tests correctly.

Test retrying has been brought down to 1 and will ideally be removed entirely as we don't want to have tests that need to be retried at all.

In follow-up PRs we can incrementally migrate integration tests to e2e, development, and production tests so that they leverage the createNext util and allow running more accurately.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Aug 31, 2021
@ijjk ijjk added the type: next label Sep 3, 2021
@ijjk ijjk marked this pull request as ready for review September 10, 2021 18:12
@ijjk
Copy link
Member Author

ijjk commented Sep 12, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js add/playwright Change
buildDuration 15.4s 15.3s -87ms
buildDurationCached 3.8s 3.7s -73ms
nodeModulesSize 47 MB 47 MB -50.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/playwright Change
/ failed reqs 0 0
/ total time (seconds) 3.308 3.367 ⚠️ +0.06
/ avg req/sec 755.67 742.48 ⚠️ -13.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.881 1.83 -0.05
/error-in-render avg req/sec 1328.94 1365.76 +36.82
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/playwright Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.6 kB 26.6 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.4 kB 70.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/playwright Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/playwright Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/playwright Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/playwright Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js add/playwright Change
buildDuration 11.8s 12s ⚠️ +159ms
buildDurationCached 5s 4.9s -90ms
nodeModulesSize 47 MB 47 MB -50.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/playwright Change
/ failed reqs 0 0
/ total time (seconds) 3.377 3.257 -0.12
/ avg req/sec 740.34 767.68 +27.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.771 1.906 ⚠️ +0.14
/error-in-render avg req/sec 1411.9 1311.5 ⚠️ -100.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/playwright Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 13.8 kB 13.8 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/playwright Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/playwright Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/playwright Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/playwright Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: f8b7a8b

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @ijjk 👏

@timneutkens timneutkens merged commit a92a5ca into vercel:canary Sep 13, 2021
@timneutkens timneutkens deleted the add/playwright branch September 13, 2021 12:36
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants