Ensure all packages are packed while tracing #28263
Merged
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Build (Decrease detected ✓)General
Page Load Tests Overall decrease
|
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.782 | 2.846 | |
| / avg req/sec | 898.79 | 878.34 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.757 | 1.834 | |
| /error-in-render avg req/sec | 1422.91 | 1363.42 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| 745.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 23.2 kB | 23.2 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 67.1 kB | 67.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 979 B | 979 B | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 329 B | 329 B | ✓ |
| dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
| head-HASH.js gzip | 351 B | 351 B | ✓ |
| hooks-HASH.js gzip | 918 B | 918 B | ✓ |
| image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
| script-HASH.js gzip | 387 B | 387 B | ✓ |
| withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 492 B | 492 B | ✓ |
| Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| index.html gzip | 539 B | 539 B | ✓ |
| link.html gzip | 550 B | 550 B | ✓ |
| withRouter.html gzip | 532 B | 532 B | ✓ |
| Overall change | 1.62 kB | 1.62 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| buildDuration | 12.4s | 12s | -439ms |
| buildDurationCached | 5.1s | 5.1s | |
| nodeModulesSize | 61.4 MB | 61.4 MB | ✓ |
Page Load Tests Overall increase ✓
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.888 | 2.778 | -0.11 |
| / avg req/sec | 865.72 | 899.91 | +34.19 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.75 | 1.709 | -0.04 |
| /error-in-render avg req/sec | 1428.26 | 1462.51 | +34.25 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| 16.HASH.js gzip | 186 B | 186 B | ✓ |
| 677f882d2ed8..HASH.js gzip | 14.1 kB | 14.1 kB | ✓ |
| framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
| main-HASH.js gzip | 10.6 kB | 10.6 kB | ✓ |
| webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
| Overall change | 68 kB | 68 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 964 B | 964 B | ✓ |
| _error-HASH.js gzip | 3.8 kB | 3.8 kB | ✓ |
| amp-HASH.js gzip | 552 B | 552 B | ✓ |
| css-HASH.js gzip | 333 B | 333 B | ✓ |
| dynamic-HASH.js gzip | 2.87 kB | 2.87 kB | ✓ |
| head-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks-HASH.js gzip | 924 B | 924 B | ✓ |
| index-HASH.js gzip | 231 B | 231 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
| script-HASH.js gzip | 2.98 kB | 2.98 kB | ✓ |
| withRouter-HASH.js gzip | 295 B | 295 B | ✓ |
| 30809af5c834..565.css gzip | 125 B | 125 B | ✓ |
| Overall change | 18.1 kB | 18.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 500 B | 500 B | ✓ |
| Overall change | 500 B | 500 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ijjk/next.js fix/trace-during-publish | Change | |
|---|---|---|---|
| index.html gzip | 585 B | 585 B | ✓ |
| link.html gzip | 597 B | 597 B | ✓ |
| withRouter.html gzip | 578 B | 578 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
styfle
reviewed
Aug 18, 2021
| fs.unlinkSync(packagePath) | ||
| }) | ||
| // remove changes to package.json files from packing | ||
| await execa('git', ['checkout', '.'], { |
There was a problem hiding this comment.
Should it be package.json instead of .?
There was a problem hiding this comment.
Would that remove changes to all package.json files in the tree or just the top-level one? This currently modifies all packages/*/package.json files to ensure we link to the packed versions correctly and then we want to undo those changes here after we're done installing
There was a problem hiding this comment.
I see. then it could be git checkout packages/*/package.json but I suppose theres no harm in checking out everything.
Also if there are additional files created you could do git clean -fd
styfle
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we pack all packages with
yarnwhen tracingnext-serverso that we can create a freshnextinstall even when the version has been bumped and it isn't available onnpmyet. This matches how we install versions not available on npm locally while generating the PR/release stats.