Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/amp attribute patcher #27700

Merged
merged 10 commits into from
Aug 3, 2021
Merged

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Aug 2, 2021

Ported amp attribute plugin to swc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Aug 2, 2021
@padmaia padmaia force-pushed the add/amp-attribute-patcher branch from 0184663 to 626211f Compare August 2, 2021 17:31
@padmaia padmaia force-pushed the add/amp-attribute-patcher branch from 626211f to 61191e0 Compare August 2, 2021 17:31
@ijjk

This comment has been minimized.

@padmaia padmaia marked this pull request as ready for review August 2, 2021 18:31
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@padmaia padmaia force-pushed the add/amp-attribute-patcher branch from 7b799c4 to bcdf595 Compare August 2, 2021 21:39
@ijjk

This comment has been minimized.

@padmaia padmaia force-pushed the add/amp-attribute-patcher branch from bcdf595 to bb59455 Compare August 3, 2021 00:41
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
buildDuration 17s 16.9s -114ms
buildDurationCached 3.8s 3.8s -9ms
nodeModulesSize 50.1 MB 50.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
/ failed reqs 0 0
/ total time (seconds) 2.988 3.03 ⚠️ +0.04
/ avg req/sec 836.81 825.1 ⚠️ -11.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.9 1.843 -0.06
/error-in-render avg req/sec 1316.07 1356.71 +40.64
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
index.html gzip 531 B 531 B
link.html gzip 542 B 542 B
withRouter.html gzip 523 B 523 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
buildDuration 13.6s 13.4s -221ms
buildDurationCached 5.3s 5.2s -35ms
nodeModulesSize 50.1 MB 50.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
/ failed reqs 0 0
/ total time (seconds) 3.007 3.037 ⚠️ +0.03
/ avg req/sec 831.42 823.16 ⚠️ -8.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.869 1.859 -0.01
/error-in-render avg req/sec 1337.67 1344.73 +7.06
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.5 kB 10.5 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.94 kB 2.94 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/amp-attribute-patcher Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 38173af

@padmaia padmaia merged commit 204445f into vercel:canary Aug 3, 2021
@padmaia padmaia deleted the add/amp-attribute-patcher branch August 3, 2021 16:55
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
* Add amp attribute transform

* Add amp attribute unit tests

* Fix ci if statements

* Checkout code in rust tests

* Add rust fixtures to eslintignore

* Add cargo config

* Configure toolchain for cross compilation
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants