-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Next.js core development sourcemaps use correct input file #27623
Merged
timneutkens
merged 1 commit into
vercel:canary
from
timneutkens:fix/sourcemap-locations-core-development
Aug 1, 2021
Merged
Ensure Next.js core development sourcemaps use correct input file #27623
timneutkens
merged 1 commit into
vercel:canary
from
timneutkens:fix/sourcemap-locations-core-development
Aug 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed while debugging that the error output lines did not make sense and found that `sourceFileName` is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.
timneutkens
requested review from
huozhi,
ijjk,
padmaia,
shuding and
styfle
as code owners
July 30, 2021 12:37
timneutkens
changed the title
Ensure Next.js core development sourcemaps use correct input line
Ensure Next.js core development sourcemaps use correct input file
Jul 30, 2021
Failing test suitesCommit: 9d90b18 test/unit/webpack-config-overrides.unit.test.js Expand output● Test suite failed to run
|
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
buildDuration | 15.3s | 15.6s | |
buildDurationCached | 3.6s | 3.5s | -96ms |
nodeModulesSize | 50.3 MB | 50.3 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.676 | 2.596 | -0.08 |
/ avg req/sec | 934.19 | 962.95 | +28.76 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.501 | 1.456 | -0.04 |
/error-in-render avg req/sec | 1665.37 | 1717.31 | +51.94 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 22.8 kB | 22.8 kB | ✓ |
webpack-HASH.js gzip | 1.5 kB | 1.5 kB | ✓ |
Overall change | 66.7 kB | 66.7 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
_app-HASH.js gzip | 980 B | 980 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 903 B | 903 B | ✓ |
image-HASH.js gzip | 4.1 kB | 4.1 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 319 B | 319 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 12.8 kB | 12.8 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
_buildManifest.js gzip | 490 B | 490 B | ✓ |
Overall change | 490 B | 490 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
index.html gzip | 530 B | 530 B | ✓ |
link.html gzip | 542 B | 542 B | ✓ |
withRouter.html gzip | 524 B | 524 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
buildDuration | 12.2s | 12s | -155ms |
buildDurationCached | 4.7s | 4.7s | -81ms |
nodeModulesSize | 50.3 MB | 50.3 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.661 | 2.58 | -0.08 |
/ avg req/sec | 939.48 | 968.89 | +29.41 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.377 | 1.397 | |
/error-in-render avg req/sec | 1814.99 | 1789.76 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
17.HASH.js gzip | 185 B | 185 B | ✓ |
677f882d2ed8..HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
main-HASH.js gzip | 10.6 kB | 10.6 kB | ✓ |
webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
Overall change | 67.7 kB | 67.7 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
_app-HASH.js gzip | 965 B | 965 B | ✓ |
_error-HASH.js gzip | 3.74 kB | 3.74 kB | ✓ |
amp-HASH.js gzip | 552 B | 552 B | ✓ |
css-HASH.js gzip | 333 B | 333 B | ✓ |
dynamic-HASH.js gzip | 2.71 kB | 2.71 kB | ✓ |
head-HASH.js gzip | 2.97 kB | 2.97 kB | ✓ |
hooks-HASH.js gzip | 911 B | 911 B | ✓ |
index-HASH.js gzip | 231 B | 231 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
script-HASH.js gzip | 2.94 kB | 2.94 kB | ✓ |
withRouter-HASH.js gzip | 294 B | 294 B | ✓ |
e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
Overall change | 17.7 kB | 17.7 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
_buildManifest.js gzip | 499 B | 499 B | ✓ |
Overall change | 499 B | 499 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/sourcemap-locations-core-development | Change | |
---|---|---|---|
index.html gzip | 578 B | 578 B | ✓ |
link.html gzip | 591 B | 591 B | ✓ |
withRouter.html gzip | 571 B | 571 B | ✓ |
Overall change | 1.74 kB | 1.74 kB | ✓ |
ijjk
added a commit
to ijjk/next.js
that referenced
this pull request
Aug 2, 2021
…file (vercel#27623)" This reverts commit f9ebc77.
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
This undoes the change from #27623 since it appears to be breaking source maps from changing the sources field in the generated source map to a relative path causing it to break jest's source map handling as can be seen in the `test-unit` CI job [here](https://github.com/vercel/next.js/runs/3214076727). This reverts commit f9ebc77.
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
…rcel#27623) Noticed while debugging that the error output lines did not make sense and found that `sourceFileName` is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
This undoes the change from vercel#27623 since it appears to be breaking source maps from changing the sources field in the generated source map to a relative path causing it to break jest's source map handling as can be seen in the `test-unit` CI job [here](https://github.com/vercel/next.js/runs/3214076727). This reverts commit f9ebc77.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while debugging that the error output lines did not make sense and found that
sourceFileName
is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples