Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Next.js core development sourcemaps use correct input file #27623

Conversation

timneutkens
Copy link
Member

Noticed while debugging that the error output lines did not make sense and found that sourceFileName is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Noticed while debugging that the error output lines did not make sense and found that `sourceFileName` is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jul 30, 2021
@timneutkens timneutkens changed the title Ensure Next.js core development sourcemaps use correct input line Ensure Next.js core development sourcemaps use correct input file Jul 30, 2021
@ijjk
Copy link
Member

ijjk commented Jul 30, 2021

Failing test suites

Commit: 9d90b18

test/unit/webpack-config-overrides.unit.test.js

Expand output

● Test suite failed to run

/home/runner/work/next.js/next.js/packages/next/dist/build/webpack/config/blocks/css/index.js: No element indexed by 1

  at ArraySet_at [as at] (../node_modules/jest-config/node_modules/source-map/lib/array-set.js:109:9)
      at Array.map (<anonymous>)
      at run.next (<anonymous>)

@ijjk
Copy link
Member

ijjk commented Jul 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
buildDuration 15.3s 15.6s ⚠️ +309ms
buildDurationCached 3.6s 3.5s -96ms
nodeModulesSize 50.3 MB 50.3 MB ⚠️ +3.03 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
/ failed reqs 0 0
/ total time (seconds) 2.676 2.596 -0.08
/ avg req/sec 934.19 962.95 +28.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.501 1.456 -0.04
/error-in-render avg req/sec 1665.37 1717.31 +51.94
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 22.8 kB 22.8 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 66.7 kB 66.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 4.1 kB 4.1 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
index.html gzip 530 B 530 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
buildDuration 12.2s 12s -155ms
buildDurationCached 4.7s 4.7s -81ms
nodeModulesSize 50.3 MB 50.3 MB ⚠️ +3.03 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
/ failed reqs 0 0
/ total time (seconds) 2.661 2.58 -0.08
/ avg req/sec 939.48 968.89 +29.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.377 1.397 ⚠️ +0.02
/error-in-render avg req/sec 1814.99 1789.76 ⚠️ -25.23
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.7 kB 67.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.94 kB 2.94 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/sourcemap-locations-core-development Change
index.html gzip 578 B 578 B
link.html gzip 591 B 591 B
withRouter.html gzip 571 B 571 B
Overall change 1.74 kB 1.74 kB
Commit: 9d90b18

@timneutkens timneutkens merged commit f9ebc77 into vercel:canary Aug 1, 2021
@timneutkens timneutkens deleted the fix/sourcemap-locations-core-development branch August 1, 2021 14:08
ijjk added a commit to ijjk/next.js that referenced this pull request Aug 2, 2021
@ijjk ijjk mentioned this pull request Aug 2, 2021
kodiakhq bot pushed a commit that referenced this pull request Aug 2, 2021
This undoes the change from #27623 since it appears to be breaking source maps from changing the sources field in the generated source map to a relative path causing it to break jest's source map handling as can be seen in the `test-unit` CI job [here](https://github.com/vercel/next.js/runs/3214076727). 

This reverts commit f9ebc77.
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
…rcel#27623)

Noticed while debugging that the error output lines did not make sense and found that `sourceFileName` is not supported in SWC yet. This is a temporary fix until @kdy1 adds the option.
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
This undoes the change from vercel#27623 since it appears to be breaking source maps from changing the sources field in the generated source map to a relative path causing it to break jest's source map handling as can be seen in the `test-unit` CI job [here](https://github.com/vercel/next.js/runs/3214076727). 

This reverts commit f9ebc77.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants