Port next-ssg getStaticProps/getServerSideProps tree shaking Babel transform to rust #27552

kdy1 · 2021-07-28T09:52:32Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes

Currently, the PR is not ready.

Remaining tasks:

swc: Improve codegen.
swc: Make testing library usable with stable rust.
next-ssg: Preserve unrelated dead code.
swc: Provide api to run resolver before custom passes.
next-ssg: should support export { _ as default } (test)
next-ssg: should support babel-style memoized function (test)
next-ssg: destructuring assignment (object) (test)
next-ssg: destructuring assignment (array) (test)
Inject export var __N_SSG = true to correct position.

I added a rust-side test because debugging rust code with jest is literally impossible.

I need some comments about unit testing. How should it be organized?
I used the existing test suite, but I also added a rust-based testing system.

kdy1 · 2021-07-28T09:55:58Z

packages/next/build/swc/.cargo/config

@@ -0,0 +1,4 @@
+[build]


This is temporary. I'll remove this after implementing support for stable rust in testing system of swc.

kdy1 · 2021-07-28T09:56:20Z

packages/next/build/swc/rust-toolchain

@@ -0,0 +1 @@
+nightly-2021-03-25


Same as above. It's temporary, and I think using stable is better.

kdy1 · 2021-07-28T09:56:58Z

packages/next/build/swc/src/transform.rs

@@ -172,7 +173,7 @@ fn process_js_custom(
        }
    };
    let config = BuiltConfig {


I think we need some way to organize passes properly.

timneutkens

Looks great 🎉

timneutkens · 2021-08-02T11:21:29Z

packages/next/build/swc/tests/fixture has to be added to .eslintignore as currently the lint step fails

padmaia · 2021-08-02T16:38:34Z

I think the CI issues actually are related. I was experiencing the same thing when I was trying to open up a PR with the new testing setup on Friday. For some reason the errors are being hidden when running yarn from the root, but you can see this task is failing to build the js files in the fixtures when running yarn in packages/next (thanks to @ijjk for helping me figure this out). The solution would be to tell the task to ignore those files or move the rust code out of build and just keep the binding there.

kdy1 · 2021-08-02T16:56:01Z

Thanks! I excluded them.

test/unit/babel-plugin-next-ssg-transform.unit.test.js

ijjk · 2021-08-02T23:16:34Z

Failing test suites

Commit: 7c152b7

test/acceptance/ReactRefreshLogBox.dev.test.js

server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=92.0.4515.107)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1415:3)

ijjk · 2021-08-03T02:48:17Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
buildDuration	13.2s	12.6s	-635ms
buildDurationCached	3.1s	3s	-131ms
nodeModulesSize	50.1 MB	50.1 MB	⚠️ +10.2 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.291	2.279	-0.01
/ avg req/sec	1091.28	1097.19	+5.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.256	1.28	⚠️ +0.02
/error-in-render avg req/sec	1990.67	1952.99	⚠️ -37.68

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	22.8 kB	22.8 kB	✓
webpack-HASH.js gzip	1.5 kB	1.5 kB	✓
Overall change	66.7 kB	66.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
_app-HASH.js gzip	980 B	980 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	904 B	904 B	✓
image-HASH.js gzip	4.13 kB	4.13 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.8 kB	12.8 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
index.html gzip	531 B	531 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.6 kB	1.6 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
buildDuration	10.2s	10.2s	⚠️ +6ms
buildDurationCached	4.2s	4s	-158ms
nodeModulesSize	50.1 MB	50.1 MB	⚠️ +10.2 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.279	2.339	⚠️ +0.06
/ avg req/sec	1096.79	1069.02	⚠️ -27.77
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.277	1.213	-0.06
/error-in-render avg req/sec	1957.46	2060.49	+103.03

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
17.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.6 kB	10.6 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	67.7 kB	67.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
_app-HASH.js gzip	965 B	965 B	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	2.94 kB	2.94 kB	✓
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.7 kB	17.7 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
_buildManifest.js gzip	499 B	499 B	✓
Overall change	499 B	499 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-next-ssg	Change
index.html gzip	577 B	577 B	✓
link.html gzip	589 B	589 B	✓
withRouter.html gzip	569 B	569 B	✓
Overall change	1.74 kB	1.74 kB	✓

Commit: 8b619c2

eric-burel · 2021-08-09T20:16:39Z

Hi guys, I am digging this PR because I'm very interested in the ability to have server-side and client-side code mixed in an isomorphic manner, I'd like to use a similar approach to define data models, form inputs, and some API endpoints in one single file.
I have only one question: why the switch to Rust for this particular feature? This doesn't sound like a part of Next.js that requires very strong performance, so I don't get why Babel and some JS would not be sufficient.

…ansform to rust (vercel#27552)

ijjk added the type: next label Jul 28, 2021

This comment has been minimized.

Sign in to view

kdy1 commented Jul 28, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

kdy1 mentioned this pull request Jul 29, 2021

fix(testing): Allow using it with stable rustc swc-project/swc#1974

Merged

1 task

timneutkens changed the title ~~Port next-ssg to rust~~ Port next-ssg getStaticProps/getServerSideProps tree shaking Babel transform to rust Jul 30, 2021

kdy1 added 24 commits August 2, 2021 00:25

Add next_ssg

c41a679

Add fxhash to dep

c4d78ea

WIP: Basical structure

2adc9c1

Port more analyzer code

dec57b1

Implement initial traversal

ffd12a5

Depend on retain_mut

35ee64a

Add some methods to Sweeper

ba3cfc7

Use repeater correctly

13cc452

Prepare testing

655695a

Enable next_ssg

bde69b2

Drop empty statements

adda5c9

Remove rust-side test

2d26e08

Update test to use swc

a65b083

Inject vars

4d7a6de

minify

44033c8

Use es2021

ed2c884

Drop more bindings

e9890e7

fixup: Lint & flag

99a1094

Properly run again

96cde1d

Run again

e8f58fb

Rename

b2dab8c

Don't mark var decl as usage

bc55d62

More work for change detection

4f97e58

rust-based testing

b55956c

Restore

c4080cc

timneutkens previously approved these changes Aug 2, 2021

View reviewed changes

Add fixtures to .eslintignore

4fab32c

kdy1 dismissed timneutkens’s stale review via 4fab32c August 2, 2021 11:46

Exclude rust-side fixtures from node build config

987fbbb

Merge branch 'canary' into swc-next-ssg

960ada8

This comment has been minimized.

Sign in to view

Fix test

9fa719e

padmaia reviewed Aug 2, 2021

View reviewed changes

test/unit/babel-plugin-next-ssg-transform.unit.test.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Restore babel test

1c6965c

This comment has been minimized.

Sign in to view

Merge branch 'canary' into swc-next-ssg

7c152b7

This comment has been minimized.

Sign in to view

Merge branch 'canary' into swc-next-ssg

8b619c2

timneutkens merged commit 61586ed into vercel:canary Aug 3, 2021

kdy1 deleted the swc-next-ssg branch August 3, 2021 12:04

frencojobs mentioned this pull request Aug 4, 2021

For Next.js 10.0 use Snowpack instead of Webpack as bundler #15152

Closed

eric-burel mentioned this pull request Aug 9, 2021

RFC: Fullstack and isomorphic package (work in progress) VulcanJS/vulcan-npm#14

Open

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021

Port next-ssg getStaticProps/getServerSideProps tree shaking Babel tr…

d254f2b

…ansform to rust (vercel#27552)

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

kdy1 self-assigned this Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port next-ssg getStaticProps/getServerSideProps tree shaking Babel transform to rust #27552

Port next-ssg getStaticProps/getServerSideProps tree shaking Babel transform to rust #27552

kdy1 commented Jul 28, 2021 •

edited

Loading

This comment has been minimized.

kdy1 Jul 28, 2021

kdy1 Jul 28, 2021

kdy1 Jul 28, 2021

This comment has been minimized.

timneutkens left a comment

timneutkens commented Aug 2, 2021

padmaia commented Aug 2, 2021

kdy1 commented Aug 2, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 2, 2021

ijjk commented Aug 3, 2021

eric-burel commented Aug 9, 2021 •

edited

Loading

		@@ -0,0 +1 @@
		nightly-2021-03-25

Port next-ssg getStaticProps/getServerSideProps tree shaking Babel transform to rust #27552

Port next-ssg getStaticProps/getServerSideProps tree shaking Babel transform to rust #27552

Conversation

kdy1 commented Jul 28, 2021 • edited Loading

Bug

Feature

Documentation / Examples

This comment has been minimized.

kdy1 Jul 28, 2021

Choose a reason for hiding this comment

kdy1 Jul 28, 2021

Choose a reason for hiding this comment

kdy1 Jul 28, 2021

Choose a reason for hiding this comment

This comment has been minimized.

timneutkens left a comment

Choose a reason for hiding this comment

timneutkens commented Aug 2, 2021

padmaia commented Aug 2, 2021

kdy1 commented Aug 2, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 2, 2021

Failing test suites

ijjk commented Aug 3, 2021

Stats from current PR

eric-burel commented Aug 9, 2021 • edited Loading

kdy1 commented Jul 28, 2021 •

edited

Loading

kdy1 commented Aug 2, 2021 •

edited

Loading

eric-burel commented Aug 9, 2021 •

edited

Loading