Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale switcher to i18n-routing example #27444

Merged
merged 4 commits into from
Jul 23, 2021
Merged

Add locale switcher to i18n-routing example #27444

merged 4 commits into from
Jul 23, 2021

Conversation

sa3dany
Copy link
Contributor

@sa3dany sa3dany commented Jul 23, 2021

Adds a local switcher component to the i18n-routing example to demonstrate how to switch between locales using next/link for dynamic getStaticProps pages.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 23, 2021
@sa3dany @ijjk
Apply suggestions from code review
e2ac183 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@ijjk ijjk changed the title add locale switcher to dynamic GSP page in i18n-routing example Add locale switcher to i18n-routing example Jul 23, 2021
ijjk
ijjk approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 9cbc4aa into vercel:canary Jul 23, 2021
@sa3dany sa3dany deleted the i18n-routing-update branch July 24, 2021 01:50
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@sa3dany @ijjk
Add locale switcher to i18n-routing example (vercel#27444)
b834849 
* add locale switcher to dynamic GSP page in i18n-routing example

* Apply suggestions from code review

Co-authored-by: JJ Kasper <jj@jjsweb.site>

* Add switcher to other pages as well

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sa3dany @ijjk