Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Layouts & Going to Production #27021

Merged
merged 11 commits into from
Jul 12, 2021
Merged

[docs] Layouts & Going to Production #27021

merged 11 commits into from
Jul 12, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Jul 8, 2021

  • Helps clear up customer confusion about how to share React state with layouts, including nested layouts
  • Provides guidance on best practices before shipping your application to production

Open to any feedback!

docs/basic-features/layouts.md Outdated Show resolved Hide resolved
@leerob
Copy link
Member Author

leerob commented Jul 8, 2021

Feedback: "I think it's worth mentioning to run Lighthouse for production builds and in incognito (to make sure extensions don't interfere)"

Edit: Done

leerob and others added 2 commits July 8, 2021 14:05
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
docs/going-to-production.md Outdated Show resolved Hide resolved
@sergioviniciuss
Copy link

hey @leerob ,
I see it explains how to share components inside a Next.js app, but what about two (or more) Next.js apps (using multi-zones).
What would you recommend? Is creating a shared NPM module to wrap header and footer under a layout component the best way?

Some references:

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jul 9, 2021
@leerob
Copy link
Member Author

leerob commented Jul 12, 2021

@timneutkens @ijjk Ready to go 😄

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@kodiakhq kodiakhq bot merged commit 26f4794 into vercel:canary Jul 12, 2021
@leerob leerob deleted the new-docs branch July 12, 2021 19:07
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
- Helps clear up customer confusion about how to share React state with layouts, including nested layouts
- Provides guidance on best practices before shipping your application to production

Open to any feedback!
@@ -0,0 +1,109 @@
---
description: Learn how to share components and state between Next.js pages with Layouts.
Copy link

@sergioviniciuss sergioviniciuss Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also have a section about how to share components between Next.js Apps when using multi-zones?

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants