Fix bug where returning { notFound: true } from GSP broke next export
#24481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort` We could just as easily omit the notFoundRoutes check, but I didn't want to mask other potential bugs that would result in missing files
|
This is also happening for me and seems like it would fix the issue I'm having. |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| buildDuration | 14s | 14s | |
| buildDurationCached | 3.5s | 3.9s | |
| nodeModulesSize | 182 MB | 182 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.968 | 3.047 | |
| / avg req/sec | 842.45 | 820.42 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.468 | 1.433 | -0.03 |
| /error-in-render avg req/sec | 1702.94 | 1744.95 | +42.01 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| 779.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 26.7 kB | 26.7 kB | ✓ |
| webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
| Overall change | 70.6 kB | 70.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 977 B | 977 B | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 311 B | 311 B | ✓ |
| css-HASH.js gzip | 328 B | 328 B | ✓ |
| dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
| head-HASH.js gzip | 351 B | 351 B | ✓ |
| hooks-HASH.js gzip | 918 B | 918 B | ✓ |
| image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
| index-HASH.js gzip | 260 B | 260 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 493 B | 493 B | ✓ |
| Overall change | 493 B | 493 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| index.html gzip | 540 B | 540 B | ✓ |
| link.html gzip | 552 B | 552 B | ✓ |
| withRouter.html gzip | 533 B | 533 B | ✓ |
| Overall change | 1.63 kB | 1.63 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| buildDuration | 7.1s | 7s | -34ms |
| buildDurationCached | 3.5s | 3.4s | -59ms |
| nodeModulesSize | 182 MB | 182 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.975 | 2.979 | 0 |
| / avg req/sec | 840.46 | 839.07 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.457 | 1.468 | |
| /error-in-render avg req/sec | 1715.85 | 1702.77 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| 675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
| 770.HASH.js gzip | 178 B | 178 B | ✓ |
| framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
| main-HASH.js gzip | 34.6 kB | 34.6 kB | ✓ |
| webpack-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.32 kB | 1.32 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 315 B | 315 B | ✓ |
| css-HASH.js gzip | 331 B | 331 B | ✓ |
| dynamic-HASH.js gzip | 2.8 kB | 2.8 kB | ✓ |
| head-HASH.js gzip | 356 B | 356 B | ✓ |
| hooks-HASH.js gzip | 637 B | 637 B | ✓ |
| image-HASH.js gzip | 573 B | 573 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
| routerDirect..HASH.js gzip | 326 B | 326 B | ✓ |
| script-HASH.js gzip | 393 B | 393 B | ✓ |
| withRouter-HASH.js gzip | 322 B | 322 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 511 B | 511 B | ✓ |
| Overall change | 511 B | 511 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | fracture91/next.js ssg-notfound-export-bug | Change | |
|---|---|---|---|
| index.html gzip | 539 B | 539 B | ✓ |
| link.html gzip | 552 B | 552 B | ✓ |
| withRouter.html gzip | 531 B | 531 B | ✓ |
| Overall change | 1.62 kB | 1.62 kB | ✓ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24422
Closes: #28203
We could just as easily omit the
notFoundRoutescheck, but I didn't want to mask other potential bugs that would result in missing files. I'm also assuming that the HTML + JSON files will either both exist or both not exist, which could be wrong. If there's a better place for the test, let me know.Unfortunately,
yarn buildalways gives me an error in the reproduction repo after following the locally compiled version instructions before and after my commit:TypeError: aSourceMapConsumer.originalPositionFor is not a function. Maybe an M1-specific bug? Consequently, I have not verified that this fixes the problem in a real app, but I could do so if this makes it into a canary version.Bug
fixes #number