Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(create-next-app): use latest examples #24048

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

jamesgeorge007
Copy link
Contributor

Update CNA test suite to consume vercel-learn-starter as the example repo.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Apr 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 14s 14.2s ⚠️ +232ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.485 2.57 ⚠️ +0.08
/ avg req/sec 1006.01 972.78 ⚠️ -33.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.345 1.329 -0.02
/error-in-render avg req/sec 1858.25 1880.95 +22.7
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 609 B 609 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 17.8s 18s ⚠️ +225ms
nodeModulesSize 46.2 MB 46.2 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.14 MB 7.14 MB

Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 14.1s 14.3s ⚠️ +145ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.452 2.547 ⚠️ +0.1
/ avg req/sec 1019.59 981.47 ⚠️ -38.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.335 1.304 -0.03
/error-in-render avg req/sec 1872.22 1917.75 +45.53
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 609 B 609 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Diffs

Diff for index.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "patwdIAmxO1ieGh7P5n-B",
+        "buildId": "wZJG_x0FUqjPc4kl0sOSj",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/patwdIAmxO1ieGh7P5n-B/_buildManifest.js"
+      src="/_next/static/wZJG_x0FUqjPc4kl0sOSj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/patwdIAmxO1ieGh7P5n-B/_ssgManifest.js"
+      src="/_next/static/wZJG_x0FUqjPc4kl0sOSj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "patwdIAmxO1ieGh7P5n-B",
+        "buildId": "wZJG_x0FUqjPc4kl0sOSj",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/patwdIAmxO1ieGh7P5n-B/_buildManifest.js"
+      src="/_next/static/wZJG_x0FUqjPc4kl0sOSj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/patwdIAmxO1ieGh7P5n-B/_ssgManifest.js"
+      src="/_next/static/wZJG_x0FUqjPc4kl0sOSj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "patwdIAmxO1ieGh7P5n-B",
+        "buildId": "wZJG_x0FUqjPc4kl0sOSj",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/patwdIAmxO1ieGh7P5n-B/_buildManifest.js"
+      src="/_next/static/wZJG_x0FUqjPc4kl0sOSj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/patwdIAmxO1ieGh7P5n-B/_ssgManifest.js"
+      src="/_next/static/wZJG_x0FUqjPc4kl0sOSj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 0e0d6d1

@ijjk
Copy link
Member

ijjk commented Apr 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 14.1s 14s -100ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.451 2.443 -0.01
/ avg req/sec 1020.06 1023.22 +3.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.281 1.285 0
/error-in-render avg req/sec 1951.1 1945.6 ⚠️ -5.5
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 609 B 609 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 17.7s 17.7s -17ms
nodeModulesSize 46.2 MB 46.2 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.14 MB 7.14 MB

Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 14.1s 14s -36ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.506 2.452 -0.05
/ avg req/sec 997.56 1019.51 +21.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.284 1.258 -0.03
/error-in-render avg req/sec 1947.31 1987.6 +40.29
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 609 B 609 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Diffs

Diff for index.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "A7IFgdkXjyfsnzuqUlJTc",
+        "buildId": "3W98Wdzm3qgGH9jq17PSs",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/A7IFgdkXjyfsnzuqUlJTc/_buildManifest.js"
+      src="/_next/static/3W98Wdzm3qgGH9jq17PSs/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/A7IFgdkXjyfsnzuqUlJTc/_ssgManifest.js"
+      src="/_next/static/3W98Wdzm3qgGH9jq17PSs/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "A7IFgdkXjyfsnzuqUlJTc",
+        "buildId": "3W98Wdzm3qgGH9jq17PSs",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/A7IFgdkXjyfsnzuqUlJTc/_buildManifest.js"
+      src="/_next/static/3W98Wdzm3qgGH9jq17PSs/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/A7IFgdkXjyfsnzuqUlJTc/_ssgManifest.js"
+      src="/_next/static/3W98Wdzm3qgGH9jq17PSs/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "A7IFgdkXjyfsnzuqUlJTc",
+        "buildId": "3W98Wdzm3qgGH9jq17PSs",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/A7IFgdkXjyfsnzuqUlJTc/_buildManifest.js"
+      src="/_next/static/3W98Wdzm3qgGH9jq17PSs/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/A7IFgdkXjyfsnzuqUlJTc/_ssgManifest.js"
+      src="/_next/static/3W98Wdzm3qgGH9jq17PSs/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 017c570

@ijjk
Copy link
Member

ijjk commented Apr 15, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 16.3s 16.6s ⚠️ +317ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.928 2.893 -0.04
/ avg req/sec 853.94 864.01 +10.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.665 1.622 -0.04
/error-in-render avg req/sec 1501.92 1541.73 +39.81
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 609 B 609 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 20.3s 20.1s -192ms
nodeModulesSize 46.2 MB 46.2 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.14 MB 7.14 MB ⚠️ +2 B

Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 16.1s 15.4s -653ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.743 2.746 0
/ avg req/sec 911.37 910.54 ⚠️ -0.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.523 1.7 ⚠️ +0.18
/error-in-render avg req/sec 1642.01 1470.52 ⚠️ -171.49
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB
_error-55112..054d.js gzip 3.68 kB 3.68 kB
amp-89a5460c..567f.js gzip 558 B 558 B
hooks-8c2e74..be37.js gzip 924 B 924 B
index-fec729..83b2.js gzip 243 B 243 B
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB
routerDirect..5759.js gzip 336 B 336 B
withRouter-1..98bf.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 609 B 609 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Diffs

Diff for index.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "8YGpkzvbsO7kej4OOSE87",
+        "buildId": "Pw0L4RVt-4AhP_0RH16jf",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8YGpkzvbsO7kej4OOSE87/_buildManifest.js"
+      src="/_next/static/Pw0L4RVt-4AhP_0RH16jf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8YGpkzvbsO7kej4OOSE87/_ssgManifest.js"
+      src="/_next/static/Pw0L4RVt-4AhP_0RH16jf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "8YGpkzvbsO7kej4OOSE87",
+        "buildId": "Pw0L4RVt-4AhP_0RH16jf",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8YGpkzvbsO7kej4OOSE87/_buildManifest.js"
+      src="/_next/static/Pw0L4RVt-4AhP_0RH16jf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8YGpkzvbsO7kej4OOSE87/_ssgManifest.js"
+      src="/_next/static/Pw0L4RVt-4AhP_0RH16jf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "8YGpkzvbsO7kej4OOSE87",
+        "buildId": "Pw0L4RVt-4AhP_0RH16jf",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8YGpkzvbsO7kej4OOSE87/_buildManifest.js"
+      src="/_next/static/Pw0L4RVt-4AhP_0RH16jf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8YGpkzvbsO7kej4OOSE87/_ssgManifest.js"
+      src="/_next/static/Pw0L4RVt-4AhP_0RH16jf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: afee4fc

@ijjk
Copy link
Member

ijjk commented Apr 16, 2021

Failing test suites

Commit: f702754

test/integration/amphtml/test/index.test.js

  • AMP Usage > AMP dev mode > should detect changes and refresh an AMP page
  • AMP Usage > AMP dev mode > should not reload unless the page is edited for an AMP page
Expand output

● AMP Usage › AMP dev mode › should detect changes and refresh an AMP page

expect(received).toBe(expected) // Object.is equality

Expected: "I'm an AMP page!"
Received: "replaced it!"

  361 |         browser = await webdriver(dynamicAppPort, '/hmr/amp')
  362 |         const text = await browser.elementByCss('p').text()
> 363 |         expect(text).toBe(`I'm an AMP page!`)
      |                      ^
  364 |
  365 |         const hmrTestPagePath = join(__dirname, '../', 'pages', 'hmr', 'amp.js')
  366 |

  at Object.<anonymous> (integration/amphtml/test/index.test.js:363:22)
      at runMicrotasks (<anonymous>)

● AMP Usage › AMP dev mode › should not reload unless the page is edited for an AMP page

TIMED OUT: /I'm an AMP page!/

replaced it!

  393 |
  394 |   if (hardError) {
> 395 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  396 |   }
  397 |   return false
  398 | }

  at check (lib/next-test-utils.js:395:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:409:9)

@ijjk
Copy link
Member

ijjk commented Apr 16, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 15.8s 15.9s ⚠️ +73ms
buildDurationCached 4.8s 4.7s -82ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +89.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.786 2.818 ⚠️ +0.03
/ avg req/sec 897.35 887.25 ⚠️ -10.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.68 1.648 -0.03
/error-in-render avg req/sec 1488.45 1516.91 +28.46
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.05 kB 7.05 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 611 B 611 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 19.5s 19.5s ⚠️ +82ms
buildDurationCached 6.9s 6.9s ⚠️ +7ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +89.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.05 kB 7.05 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles Overall decrease ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_error.js 1.39 MB 1.39 MB -2 B
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.14 MB 7.14 MB -2 B

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 13.3s 13.5s ⚠️ +177ms
buildDurationCached 5.5s 5.4s -96ms
nodeModulesSize 46.2 MB 46.2 MB ⚠️ +89.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.786 2.814 ⚠️ +0.03
/ avg req/sec 897.5 888.43 ⚠️ -9.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.63 1.685 ⚠️ +0.06
/error-in-render avg req/sec 1533.88 1483.93 ⚠️ -49.95
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.12 kB 7.12 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
hooks-HASH.js gzip 888 B 888 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
Overall change 8.89 kB 8.89 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 371 B 371 B
Overall change 371 B 371 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 612 B 612 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: f702754

@timneutkens
Copy link
Member

Thanks!

@ijjk
Copy link
Member

ijjk commented Apr 16, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 14.7s 14.7s -1ms
buildDurationCached 4.5s 4.4s -87ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.668 2.692 ⚠️ +0.02
/ avg req/sec 937.09 928.74 ⚠️ -8.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.591 1.53 -0.06
/error-in-render avg req/sec 1571.08 1633.64 +62.56
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.05 kB 7.05 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 611 B 611 B
link.html gzip 616 B 616 B
withRouter.html gzip 605 B 605 B
Overall change 1.83 kB 1.83 kB

Serverless Mode
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 19s 18.4s -664ms
buildDurationCached 6.4s 6.4s -19ms
nodeModulesSize 46.2 MB 46.2 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
597-HASH.js gzip 13.3 kB 13.3 kB
778-HASH.js gzip 7.05 kB 7.05 kB
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 151 B 151 B
webpack-HASH.js gzip 993 B 993 B
Overall change 60.8 kB 60.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-HASH.js gzip 1.3 kB 1.3 kB
_error-HASH.js gzip 3.68 kB 3.68 kB
amp-HASH.js gzip 558 B 558 B
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 243 B 243 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 336 B 336 B
withRouter-HASH.js gzip 334 B 334 B
Overall change 9.03 kB 9.03 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 349 B 349 B
Overall change 349 B 349 B
Serverless bundles
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_error.js 1.39 MB 1.39 MB
404.html 2.76 kB 2.76 kB
500.html 2.75 kB 2.75 kB
amp.amp.html 10.7 kB 10.7 kB
amp.html 1.96 kB 1.96 kB
hooks.html 2.01 kB 2.01 kB
index.js 1.39 MB 1.39 MB
link.js 1.45 MB 1.45 MB
routerDirect.js 1.44 MB 1.44 MB
withRouter.js 1.44 MB 1.44 MB
Overall change 7.14 MB 7.14 MB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
buildDuration 11.8s 12.5s ⚠️ +651ms
buildDurationCached 4.9s 4.9s ⚠️ +3ms
nodeModulesSize 46.2 MB 46.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
/ failed reqs 0 0
/ total time (seconds) 2.661 2.642 -0.02
/ avg req/sec 939.65 946.33 +6.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.493 1.46 -0.03
/error-in-render avg req/sec 1674.4 1711.92 +37.52
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.12 kB 7.12 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 536 B 536 B
hooks-HASH.js gzip 888 B 888 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
Overall change 8.89 kB 8.89 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
_buildManifest.js gzip 371 B 371 B
Overall change 371 B 371 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js tests/integration Change
index.html gzip 612 B 612 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: c05c66d

@kodiakhq kodiakhq bot merged commit 4b8e539 into vercel:canary Apr 16, 2021
@jamesgeorge007 jamesgeorge007 deleted the tests/integration branch April 16, 2021 13:40
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
Update CNA test suite to consume [vercel-learn-starter](https://github.com/vercel/next-learn-starter) as the example repo.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants