Increase base Lighthouse score of default Create Next App template #23887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Apr 11, 2021
| @@ -57,7 +58,13 @@ export default function Home() { | |||
| rel="noopener noreferrer" | |||
| > | |||
| Powered by{' '} | |||
| <img src="/vercel.svg" alt="Vercel Logo" className={styles.logo} /> | |||
| <img | |||
There was a problem hiding this comment.
I was thinking of adding next/image here but wasn't sure for the purpose of the default template did you want to include it? I can update to use if so.
There was a problem hiding this comment.
Yeah feel free to add it in a separate PR 👍
|
How did you run these numbers? This change shouldn't have that type of effect, sounds like it was ran on a local machine 🤔 |
|
@timneutkens yeah these were just run locally that is why metrics are shifting. (sorry should have cut them out of the screenshot) Main figures effected by these changes are SEO and Accessibility. Edit: The numbers increased due to fixing two rules that were failing in the Lighthouse report.
|
timneutkens
approved these changes
Apr 12, 2021
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
Follow PR to #23887 to add next/image. Only other change was wrapping the image in a span to allow for the margin that was previously on the actual `<img>` ## Documentation / Examples - [x] Make sure the linting passes
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
Follow PR to vercel#23887 to add next/image. Only other change was wrapping the image in a span to allow for the margin that was previously on the actual `<img>` ## Documentation / Examples - [x] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small update to increase the base lighthouse score of the default template for Create Next App.
Before:
After:
To get a full 💯 sweep,
<html>would need a lang attribute set. I think adding a custom document or i18n to the default template would probably be just a bit too much for such a simple template.Documentation / Examples