Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript types. #23771

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Fix typescript types. #23771

merged 5 commits into from
Apr 15, 2021

Conversation

sahilrajput03
Copy link
Contributor

Fix typescript type for cache and null check in mutation result.

Bug

That issue deals with -

  • Return the codeflow if data is not returned from the mutation, and that fixes this warning.
    Screenshot from 2021-04-07 18-24-44

  • Supply typescript typings for the target cache object.
    Screenshot from 2021-04-07 18-52-15

Thanks.!

@sahilrajput03
Fix typescript types.
e2289f5 
Fix typescript type for cache and null check in mutation result.
@ijjk ijjk added the examples Issue was opened via the examples template. label Apr 7, 2021
@sahilrajput03
Copy link
Contributor Author

What is the status of this PR?

leerob
leerob previously approved these changes Apr 15, 2021
View reviewed changes
@sahilrajput03 sahilrajput03 requested a review from leerob April 15, 2021 18:51
@sahilrajput03
Copy link
Contributor Author

@leerob , I fixed the formatting in a new commit, please review it so this can be merged finally.

@kodiakhq kodiakhq bot merged commit 15133b4 into vercel:canary Apr 15, 2021
@sahilrajput03 sahilrajput03 deleted the patch-1 branch April 15, 2021 18:56
@sahilrajput03
Copy link
Contributor Author

Great!! Thats real fast merge, the ci is developed in a pretty efficient and powerful way!
Thanks leerob.!

SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@sahilrajput03 @SokratisVidros
Fix typescript types. (vercel#23771)
5c8b93f 
Fix typescript type for cache and null check in mutation result.

## Bug

- fixes : vercel#23770

**That issue deals with -**

- Return the codeflow if data is not returned from the mutation, and that fixes this warning.
![Screenshot from 2021-04-07 18-24-44](https://user-images.githubusercontent.com/31458531/113873069-18353a80-97d2-11eb-8c8c-9e9c9d280f95.png)

- Supply typescript typings for the target cache object.
![Screenshot from 2021-04-07 18-52-15](https://user-images.githubusercontent.com/31458531/113873504-80841c00-97d2-11eb-9b14-17d16a524c84.png)

Thanks.!
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix typescript type error.
3 participants
@sahilrajput03 @leerob @ijjk