Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update webpack to 5.30 #23612

Merged
merged 1 commit into from
Apr 1, 2021
Merged

update webpack to 5.30 #23612

merged 1 commit into from
Apr 1, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 1, 2021

  • has some memory usage improvements
  • after a while cache entries that are unused and already persistent to disk are removed from the memory cache
    • When are read again, they are restored from disk again
    • Should play well together with adding and removing pages due to on-demand-entries

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the type: next label Apr 1, 2021
@ijjk
Copy link
Member

ijjk commented Apr 1, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.30 Change
buildDuration 12.4s 12.7s ⚠️ +288ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +15.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.30 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.147 2.151 0
/ avg req/sec 1164.44 1162.27 ⚠️ -2.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.352 1.311 -0.04
/error-in-render avg req/sec 1849.3 1906.45 +57.15
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.30 Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.30 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.30 Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.30 Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.30 Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.30 Change
buildDuration 14.7s 14.6s -79ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +15.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.30 Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.30 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.30 Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.30 Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js webpack/5.30 Change
_error.js 1.36 MB 1.36 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.36 MB 1.36 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.41 MB 1.41 MB ✓
withRouter.js 1.41 MB 1.41 MB ✓
Overall change 6.99 MB 6.99 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/5.30 Change
buildDuration 14.5s 14.9s ⚠️ +382ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +15.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.30 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.092 2.107 ⚠️ +0.02
/ avg req/sec 1195.08 1186.27 ⚠️ -8.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.348 1.324 -0.02
/error-in-render avg req/sec 1854.21 1888.85 +34.64
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.30 Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-84582755..aa9b.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.30 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.30 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.30 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.30 Change
index.html gzip 610 B 610 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "-3dGanrd7sH9-dSbEmgG1",
+        "buildId": "oRWFk4fsO0DFGbHJGaC8h",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-3dGanrd7sH9-dSbEmgG1/_buildManifest.js"
+      src="/_next/static/oRWFk4fsO0DFGbHJGaC8h/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-3dGanrd7sH9-dSbEmgG1/_ssgManifest.js"
+      src="/_next/static/oRWFk4fsO0DFGbHJGaC8h/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "-3dGanrd7sH9-dSbEmgG1",
+        "buildId": "oRWFk4fsO0DFGbHJGaC8h",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-3dGanrd7sH9-dSbEmgG1/_buildManifest.js"
+      src="/_next/static/oRWFk4fsO0DFGbHJGaC8h/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-3dGanrd7sH9-dSbEmgG1/_ssgManifest.js"
+      src="/_next/static/oRWFk4fsO0DFGbHJGaC8h/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "-3dGanrd7sH9-dSbEmgG1",
+        "buildId": "oRWFk4fsO0DFGbHJGaC8h",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-3dGanrd7sH9-dSbEmgG1/_buildManifest.js"
+      src="/_next/static/oRWFk4fsO0DFGbHJGaC8h/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-3dGanrd7sH9-dSbEmgG1/_ssgManifest.js"
+      src="/_next/static/oRWFk4fsO0DFGbHJGaC8h/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ea7ec0f

@kodiakhq kodiakhq bot merged commit 0ad805f into canary Apr 1, 2021
@kodiakhq kodiakhq bot deleted the webpack/5.30 branch April 1, 2021 19:25
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@sokra @SokratisVidros
update webpack to 5.30 (vercel#23612)
e432e72 
* has some memory usage improvements
* after a while cache entries that are unused and already persistent to disk are removed from the memory cache
  * When are read again, they are restored from disk again
  * Should play well together with adding and removing pages due to on-demand-entries

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2021
Merged
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@sokra
update webpack to 5.30 (vercel#23612)
8ac46f4 
* has some memory usage improvements
* after a while cache entries that are unused and already persistent to disk are removed from the memory cache
  * When are read again, they are restored from disk again
  * Should play well together with adding and removing pages due to on-demand-entries

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @ijjk