Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add separate progress output for typechecking #23226

Merged
merged 2 commits into from
Mar 20, 2021
Merged

add separate progress output for typechecking #23226

merged 2 commits into from
Mar 20, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 19, 2021 •
edited by timneutkens
Loading

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

Fixes #23240

@sokra sokra force-pushed the feature/typecheck-spinner branch from a783bc5 to 790e4d0 Compare March 19, 2021 18:12
@ijjk
Copy link
Member

ijjk commented Mar 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
buildDuration 9.9s 9.9s ⚠️ +67ms
nodeModulesSize 43.6 MB 43.6 MB ⚠️ +574 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.728 1.721 -0.01
/ avg req/sec 1446.61 1452.89 +6.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.053 1.116 ⚠️ +0.06
/error-in-render avg req/sec 2373.19 2239.47 ⚠️ -133.72
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
index.html gzip 613 B 613 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
buildDuration 12.3s 11.5s -744ms
nodeModulesSize 43.6 MB 43.6 MB ⚠️ +574 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
buildDuration 11.7s 11.4s -291ms
nodeModulesSize 43.6 MB 43.6 MB ⚠️ +574 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.675 1.667 -0.01
/ avg req/sec 1492.7 1499.85 +7.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.1 1.126 ⚠️ +0.03
/error-in-render avg req/sec 2272.57 2220.99 ⚠️ -51.58
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.1 kB 7.1 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_app-d0eb668..79ef.js gzip 1.28 kB 1.28 kB ✓
_error-d12ff..6063.js gzip 3.4 kB 3.4 kB ✓
amp-127483e4..9cd8.js gzip 560 B 560 B ✓
hooks-75994b..62d3.js gzip 924 B 924 B ✓
index-ac1ee6..819e.js gzip 243 B 243 B ✓
link-1cd4709..71e5.js gzip 1.65 kB 1.65 kB ✓
routerDirect..4d90.js gzip 333 B 333 B ✓
withRouter-0..60b0.js gzip 329 B 329 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
_buildManifest.js gzip 324 B 324 B ✓
Overall change 324 B 324 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/typecheck-spinner Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "B6g1xZd4LSkctnsY-SvwS",
+        "buildId": "fqRUytcQpZ4xP5tUAX_mw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/B6g1xZd4LSkctnsY-SvwS/_buildManifest.js"
+      src="/_next/static/fqRUytcQpZ4xP5tUAX_mw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/B6g1xZd4LSkctnsY-SvwS/_ssgManifest.js"
+      src="/_next/static/fqRUytcQpZ4xP5tUAX_mw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "B6g1xZd4LSkctnsY-SvwS",
+        "buildId": "fqRUytcQpZ4xP5tUAX_mw",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/B6g1xZd4LSkctnsY-SvwS/_buildManifest.js"
+      src="/_next/static/fqRUytcQpZ4xP5tUAX_mw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/B6g1xZd4LSkctnsY-SvwS/_ssgManifest.js"
+      src="/_next/static/fqRUytcQpZ4xP5tUAX_mw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "B6g1xZd4LSkctnsY-SvwS",
+        "buildId": "fqRUytcQpZ4xP5tUAX_mw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/B6g1xZd4LSkctnsY-SvwS/_buildManifest.js"
+      src="/_next/static/fqRUytcQpZ4xP5tUAX_mw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/B6g1xZd4LSkctnsY-SvwS/_ssgManifest.js"
+      src="/_next/static/fqRUytcQpZ4xP5tUAX_mw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 790e4d0

@kodiakhq kodiakhq bot merged commit 8c72806 into canary Mar 20, 2021
@kodiakhq kodiakhq bot deleted the feature/typecheck-spinner branch March 20, 2021 19:11
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@sokra
add separate progress output for typechecking (vercel#23226)
ef5b8d1 
## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes

Fixes vercel#23240
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add separate log line for type checking
3 participants
@sokra @ijjk @timneutkens