Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename to NEXT_WEBPACK_LOGGING #23186

Merged
merged 1 commit into from
Mar 18, 2021
Merged

rename to NEXT_WEBPACK_LOGGING #23186

merged 1 commit into from
Mar 18, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 18, 2021

as vercel doesn't allow env vars starting with _

@ijjk
Copy link
Member

ijjk commented Mar 18, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
buildDuration 12.4s 12.3s -169ms
nodeModulesSize 43.6 MB 43.6 MB -18 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.091 2.098 ⚠️ +0.01
/ avg req/sec 1195.35 1191.64 ⚠️ -3.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.319 1.336 ⚠️ +0.02
/error-in-render avg req/sec 1896.07 1871.44 ⚠️ -24.63
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
index.html gzip 614 B 614 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
buildDuration 14.4s 14.4s ⚠️ +3ms
nodeModulesSize 43.6 MB 43.6 MB -18 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
buildDuration 14.4s 14.5s ⚠️ +34ms
nodeModulesSize 43.6 MB 43.6 MB -18 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.127 2.141 ⚠️ +0.01
/ avg req/sec 1175.56 1167.94 ⚠️ -7.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.313 1.29 -0.02
/error-in-render avg req/sec 1904.43 1938.23 +33.8
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.1 kB 7.1 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_app-d0eb668..79ef.js gzip 1.28 kB 1.28 kB ✓
_error-d12ff..6063.js gzip 3.4 kB 3.4 kB ✓
amp-127483e4..9cd8.js gzip 560 B 560 B ✓
hooks-75994b..62d3.js gzip 924 B 924 B ✓
index-ac1ee6..819e.js gzip 243 B 243 B ✓
link-1cd4709..71e5.js gzip 1.65 kB 1.65 kB ✓
routerDirect..4d90.js gzip 333 B 333 B ✓
withRouter-0..60b0.js gzip 329 B 329 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
_buildManifest.js gzip 324 B 324 B ✓
Overall change 324 B 324 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/rename-webpack-logging-var Change
index.html gzip 586 B 586 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "-uJvmFqM5N9MKz6-vwiG4",
+        "buildId": "ElBFTig6c7F-VcG6zHBHf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-uJvmFqM5N9MKz6-vwiG4/_buildManifest.js"
+      src="/_next/static/ElBFTig6c7F-VcG6zHBHf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-uJvmFqM5N9MKz6-vwiG4/_ssgManifest.js"
+      src="/_next/static/ElBFTig6c7F-VcG6zHBHf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "-uJvmFqM5N9MKz6-vwiG4",
+        "buildId": "ElBFTig6c7F-VcG6zHBHf",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-uJvmFqM5N9MKz6-vwiG4/_buildManifest.js"
+      src="/_next/static/ElBFTig6c7F-VcG6zHBHf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-uJvmFqM5N9MKz6-vwiG4/_ssgManifest.js"
+      src="/_next/static/ElBFTig6c7F-VcG6zHBHf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "-uJvmFqM5N9MKz6-vwiG4",
+        "buildId": "ElBFTig6c7F-VcG6zHBHf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-uJvmFqM5N9MKz6-vwiG4/_buildManifest.js"
+      src="/_next/static/ElBFTig6c7F-VcG6zHBHf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-uJvmFqM5N9MKz6-vwiG4/_ssgManifest.js"
+      src="/_next/static/ElBFTig6c7F-VcG6zHBHf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 42ed184

@kodiakhq kodiakhq bot merged commit b267635 into canary Mar 18, 2021
@kodiakhq kodiakhq bot deleted the bugfix/rename-webpack-logging-var branch March 18, 2021 12:53
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@sokra
rename to NEXT_WEBPACK_LOGGING (vercel#23186)
10dea51 
as vercel doesn't allow env vars starting with _
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @timneutkens