Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting latest stable tag for stats #21753

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Fix getting latest stable tag for stats #21753

merged 3 commits into from
Feb 1, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 1, 2021

This ensures we get the latest tag not relying on the order of the tags in the output

timneutkens
timneutkens previously approved these changes Feb 1, 2021
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk requested a review from timneutkens February 1, 2021 17:56
@ijjk
Copy link
Member Author

ijjk commented Feb 1, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
buildDuration 12.2s 12s -228ms
nodeModulesSize 75 MB 75 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.529 2.489 -0.04
/ avg req/sec 988.4 1004.22 +15.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.749 1.734 -0.02
/error-in-render avg req/sec 1429.04 1442.08 +13.04
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
buildDuration 14.4s 14.6s ⚠️ +155ms
nodeModulesSize 75 MB 75 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
buildDuration 14.4s 14.9s ⚠️ +515ms
nodeModulesSize 75 MB 75 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.511 2.445 -0.07
/ avg req/sec 995.75 1022.32 +26.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.737 1.689 -0.05
/error-in-render avg req/sec 1439.34 1480.36 +41.02
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js stats/fix-latest-stable Change
index.html gzip 586 B 586 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "0wbPCeLaI-bnukGEKZDGr",
+        "buildId": "uEYU20AcGw8dHoUK8jrKB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0wbPCeLaI-bnukGEKZDGr/_buildManifest.js"
+      src="/_next/static/uEYU20AcGw8dHoUK8jrKB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0wbPCeLaI-bnukGEKZDGr/_ssgManifest.js"
+      src="/_next/static/uEYU20AcGw8dHoUK8jrKB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "0wbPCeLaI-bnukGEKZDGr",
+        "buildId": "uEYU20AcGw8dHoUK8jrKB",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0wbPCeLaI-bnukGEKZDGr/_buildManifest.js"
+      src="/_next/static/uEYU20AcGw8dHoUK8jrKB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0wbPCeLaI-bnukGEKZDGr/_ssgManifest.js"
+      src="/_next/static/uEYU20AcGw8dHoUK8jrKB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "0wbPCeLaI-bnukGEKZDGr",
+        "buildId": "uEYU20AcGw8dHoUK8jrKB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0wbPCeLaI-bnukGEKZDGr/_buildManifest.js"
+      src="/_next/static/uEYU20AcGw8dHoUK8jrKB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0wbPCeLaI-bnukGEKZDGr/_ssgManifest.js"
+      src="/_next/static/uEYU20AcGw8dHoUK8jrKB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6fdb6e4

@kodiakhq kodiakhq bot merged commit b6c3d9b into vercel:canary Feb 1, 2021
@Timer Timer deleted the stats/fix-latest-stable branch February 1, 2021 21:07
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @Timer @timneutkens