Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send url to gtm.pageview #21747

Merged
merged 3 commits into from
Feb 3, 2021
Merged

fix: send url to gtm.pageview #21747

merged 3 commits into from
Feb 3, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 1, 2021 •
edited
Loading

gtm.pageview was called without sending an actual URL, while it is required here:

next.js/examples/with-google-tag-manager/lib/gtm.js

Lines 3 to 6 in 36aeca8

export const pageview = (url) => {
window.dataLayer.push({
event: 'pageview',
page: url,

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 1, 2021
@kodiakhq kodiakhq bot merged commit e750f43 into vercel:canary Feb 3, 2021
@balazsorban44 balazsorban44 deleted the patch-5 branch February 3, 2021 17:01
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balazsorban44 @timneutkens @ijjk