Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script loader tests #21730

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 1, 2021

This updates to not modify elements rendered in the react tree with custom scripts while testing since react may remove these eliminates during hydration causing the tests to fail sometimes.

x-ref: #20786 (comment)

@ijjk
Copy link
Member Author

ijjk commented Feb 1, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/script-loader-test Change
buildDuration 8.8s 8.7s -174ms
nodeModulesSize 75 MB 75 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/script-loader-test Change
/ failed reqs 0 0
/ total time (seconds) 1.715 1.804 ⚠️ +0.09
/ avg req/sec 1457.43 1385.48 ⚠️ -71.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.092 1.078 -0.01
/error-in-render avg req/sec 2289.95 2319.81 +29.86
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/script-loader-test Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/script-loader-test Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/script-loader-test Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary ijjk/next.js update/script-loader-test Change
buildDuration 10.2s 10.5s ⚠️ +331ms
nodeModulesSize 75 MB 75 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/script-loader-test Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/script-loader-test Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/script-loader-test Change
buildDuration 10.7s 10.5s -156ms
nodeModulesSize 75 MB 75 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/script-loader-test Change
/ failed reqs 0 0
/ total time (seconds) 1.725 1.74 ⚠️ +0.01
/ avg req/sec 1448.89 1436.81 ⚠️ -12.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.077 1.102 ⚠️ +0.03
/error-in-render avg req/sec 2320.39 2268.55 ⚠️ -51.84
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/script-loader-test Change
597-6c246419..806f.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.57 kB 6.57 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/script-loader-test Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB
_error-7a100..a392.js gzip 3.38 kB 3.38 kB
hooks-f7e199..11b9.js gzip 904 B 904 B
index-3dc22c..ffbb.js gzip 232 B 232 B
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB
routerDirect..323a.js gzip 308 B 308 B
withRouter-a..2ef8.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/script-loader-test Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/script-loader-test Change
index.html gzip 584 B 584 B
link.html gzip 592 B 592 B
withRouter.html gzip 577 B 577 B
Overall change 1.75 kB 1.75 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "V5iae4jvTkHvf5pfd9xqb",
+        "buildId": "DiT4a3pIOo3pTvU1Jf8ba",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/V5iae4jvTkHvf5pfd9xqb/_buildManifest.js"
+      src="/_next/static/DiT4a3pIOo3pTvU1Jf8ba/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/V5iae4jvTkHvf5pfd9xqb/_ssgManifest.js"
+      src="/_next/static/DiT4a3pIOo3pTvU1Jf8ba/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "V5iae4jvTkHvf5pfd9xqb",
+        "buildId": "DiT4a3pIOo3pTvU1Jf8ba",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/V5iae4jvTkHvf5pfd9xqb/_buildManifest.js"
+      src="/_next/static/DiT4a3pIOo3pTvU1Jf8ba/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/V5iae4jvTkHvf5pfd9xqb/_ssgManifest.js"
+      src="/_next/static/DiT4a3pIOo3pTvU1Jf8ba/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "V5iae4jvTkHvf5pfd9xqb",
+        "buildId": "DiT4a3pIOo3pTvU1Jf8ba",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/V5iae4jvTkHvf5pfd9xqb/_buildManifest.js"
+      src="/_next/static/DiT4a3pIOo3pTvU1Jf8ba/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/V5iae4jvTkHvf5pfd9xqb/_ssgManifest.js"
+      src="/_next/static/DiT4a3pIOo3pTvU1Jf8ba/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: fad971d

@ijjk ijjk marked this pull request as ready for review February 1, 2021 05:18
@timneutkens timneutkens merged commit bd0b650 into vercel:canary Feb 1, 2021
@timneutkens timneutkens deleted the update/script-loader-test branch February 1, 2021 09:00
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants