Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with-react-intl example #20763

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Jan 5, 2021

Fixes: #20713

yarn dev and yarn build had different issues.

For yarn build, the trailing slash in formatjs compile-folder command is not necessary.
For yarn dev, I updated ts-node to 8.0.1 (related to TypeStrong/ts-node#762)

@ijjk ijjk added the examples Issue was opened via the examples template. label Jan 5, 2021
@ijjk
Copy link
Member

ijjk commented Jan 5, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
buildDuration 10s 10.1s ⚠️ +36ms
nodeModulesSize 80.6 MB 80.6 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
/ failed reqs 0 0
/ total time (seconds) 2.075 2.068 -0.01
/ avg req/sec 1204.71 1208.71 +4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.456 1.54 ⚠️ +0.08
/error-in-render avg req/sec 1716.92 1623.38 ⚠️ -93.54
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
677f882d2ed8..396f.js gzip 13 kB 13 kB
framework.HASH.js gzip 39 kB 39 kB
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.3 kB 59.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-705099c..c35d.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
buildDuration 12.3s 11.9s -376ms
nodeModulesSize 80.6 MB 80.6 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
677f882d2ed8..396f.js gzip 13 kB 13 kB
framework.HASH.js gzip 39 kB 39 kB
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.3 kB 59.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-705099c..c35d.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/react-intl-example Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.17 MB 5.17 MB
Commit: 6011b9e

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@lfades lfades merged commit b6c6770 into vercel:canary Jan 5, 2021
@kaykdm kaykdm deleted the fix/react-intl-example branch January 18, 2021 04:58
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[examples, react-intl] npm run build fails
3 participants