Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Fast Refresh tests with webpack@5 #20543

Merged
merged 4 commits into from
Dec 28, 2020
Merged

fix Fast Refresh tests with webpack@5 #20543

merged 4 commits into from
Dec 28, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Dec 28, 2020

This pull request fixes our failing CI for webpack 5.

Fixes #18678

@vercel vercel bot temporarily deployed to Preview December 28, 2020 18:32 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
buildDuration 10.7s 10.6s -105ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +931 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.058 2.097 ⚠️ +0.04
/ avg req/sec 1214.51 1192.15 ⚠️ -22.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.358 1.299 -0.06
/error-in-render avg req/sec 1841.52 1924.38 +82.86
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
677f882d2ed8..1e91.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
buildDuration 12.5s 12.6s ⚠️ +104ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +931 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
677f882d2ed8..1e91.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: e6cd18e

@Timer Timer marked this pull request as ready for review December 28, 2020 18:48
ijjk
ijjk approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@vercel vercel bot temporarily deployed to Preview December 28, 2020 18:56 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
buildDuration 8.7s 8.9s ⚠️ +157ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +931 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.736 1.724 -0.01
/ avg req/sec 1439.91 1449.87 +9.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.098 1.088 -0.01
/error-in-render avg req/sec 2277.03 2298.57 +21.54
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
677f882d2ed8..1e91.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
buildDuration 10.5s 10.3s -183ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +931 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
677f882d2ed8..1e91.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/webpack-5-ci Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: a15828c

@Timer Timer merged commit 5f311cd into vercel:canary Dec 28, 2020
@Timer Timer deleted the hotfix/webpack-5-ci branch December 28, 2020 19:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix React 17/Webpack 5 CI
2 participants
@Timer @ijjk