Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link.md #20435

Merged
merged 3 commits into from
Jan 3, 2021
Merged

Update link.md #20435

merged 3 commits into from
Jan 3, 2021

Conversation

fredmontet
Copy link
Contributor

Added the locale prop in the Link documentation. At the moment it is only stated in the i18n doc.

@fredmontet
Update link.md
f0fe56e 
Added the `locale` prop in the Link documentation. At the moment it is only stated in the i18n doc.
@vercel vercel bot temporarily deployed to Preview December 23, 2020 21:38 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 23, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary fredmontet/next.js patch-2 Change
buildDuration 8.8s 8.9s ⚠️ +99ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary fredmontet/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.734 1.758 ⚠️ +0.02
/ avg req/sec 1441.57 1422.33 ⚠️ -19.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.13 1.062 -0.07
/error-in-render avg req/sec 2211.89 2354.49 +142.6
Client Bundles (main, webpack, commons)
vercel/next.js canary fredmontet/next.js patch-2 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary fredmontet/next.js patch-2 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary fredmontet/next.js patch-2 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary fredmontet/next.js patch-2 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary fredmontet/next.js patch-2 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary fredmontet/next.js patch-2 Change
buildDuration 10.4s 10.4s -23ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary fredmontet/next.js patch-2 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary fredmontet/next.js patch-2 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary fredmontet/next.js patch-2 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary fredmontet/next.js patch-2 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary fredmontet/next.js patch-2 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: f0fe56e

@ijjk
Copy link
Member

ijjk commented Jan 3, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary fredmontet/next.js patch-2 Change
buildDuration 8.7s 8.5s -155ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary fredmontet/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.698 1.722 ⚠️ +0.02
/ avg req/sec 1472.34 1451.73 ⚠️ -20.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.057 1.081 ⚠️ +0.02
/error-in-render avg req/sec 2365.33 2313.37 ⚠️ -51.96
Client Bundles (main, webpack, commons)
vercel/next.js canary fredmontet/next.js patch-2 Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary fredmontet/next.js patch-2 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary fredmontet/next.js patch-2 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary fredmontet/next.js patch-2 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary fredmontet/next.js patch-2 Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary fredmontet/next.js patch-2 Change
buildDuration 10.3s 10.1s -206ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary fredmontet/next.js patch-2 Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary fredmontet/next.js patch-2 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary fredmontet/next.js patch-2 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary fredmontet/next.js patch-2 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary fredmontet/next.js patch-2 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 4ccfefb

@timneutkens
Copy link
Member

Thanks! Made some modifications!

@ijjk
Copy link
Member

ijjk commented Jan 3, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary fredmontet/next.js patch-2 Change
buildDuration 8.5s 8.3s -194ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary fredmontet/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.616 1.596 -0.02
/ avg req/sec 1546.79 1566.7 +19.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.048 1.065 ⚠️ +0.02
/error-in-render avg req/sec 2386.54 2346.87 ⚠️ -39.67
Client Bundles (main, webpack, commons)
vercel/next.js canary fredmontet/next.js patch-2 Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary fredmontet/next.js patch-2 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary fredmontet/next.js patch-2 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary fredmontet/next.js patch-2 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary fredmontet/next.js patch-2 Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary fredmontet/next.js patch-2 Change
buildDuration 10.7s 10.4s -324ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary fredmontet/next.js patch-2 Change
677f882d2ed8..42af.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a9a6f0d..a96d.js gzip 6.59 kB 6.59 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary fredmontet/next.js patch-2 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary fredmontet/next.js patch-2 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary fredmontet/next.js patch-2 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary fredmontet/next.js patch-2 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: b131968

@kodiakhq kodiakhq bot merged commit 98752eb into vercel:canary Jan 3, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredmontet @ijjk @timneutkens