Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fallback font tag repetition #20382

Merged
merged 3 commits into from
Dec 30, 2020
Merged

Fix: fallback font tag repetition #20382

merged 3 commits into from
Dec 30, 2020

Conversation

prateekbh
Copy link
Contributor

@prateekbh prateekbh commented Dec 22, 2020 •
edited
Loading

partially fixes #20341

  • Makes sure that font fallback does not get repeated for every request.
  • Adds a test for the same.

@vercel vercel bot temporarily deployed to Preview December 22, 2020 05:13 Inactive
@vercel vercel bot temporarily deployed to Preview December 22, 2020 05:15 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 22, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
buildDuration 10.2s 10.3s ⚠️ +25ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +279 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.001 2.032 ⚠️ +0.03
/ avg req/sec 1249.37 1230.53 ⚠️ -18.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.266 1.339 ⚠️ +0.07
/error-in-render avg req/sec 1974.05 1867.7 ⚠️ -106.35
Client Bundles (main, webpack, commons)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-72193d1..1356.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
index.html gzip 613 B 613 B ✓
link.html gzip 618 B 618 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
buildDuration 12s 12.1s ⚠️ +99ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +279 B
Client Bundles (main, webpack, commons)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-72193d1..1356.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_error.js 1 MB 1 MB ⚠️ +94 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +94 B
link.js 1.06 MB 1.06 MB ⚠️ +94 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +94 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +94 B
Overall change 5.16 MB 5.16 MB ⚠️ +470 B
Commit: 07891a2

@vercel vercel bot temporarily deployed to Preview December 30, 2020 23:13 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
buildDuration 9s 8.9s -121ms
nodeModulesSize 83 MB 83 MB ⚠️ +279 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.826 2.748 ⚠️ +0.92
/ avg req/sec 1368.77 909.89 ⚠️ -458.88
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.112 1.147 ⚠️ +0.03
/error-in-render avg req/sec 2247.42 2178.85 ⚠️ -68.57
Client Bundles (main, webpack, commons)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
677f882d2ed8..6cec.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3b46b61..4d69.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-1a1f628..eeb5.js gzip 1.61 kB 1.61 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
index.html gzip 615 B 615 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 610 B 610 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
buildDuration 11s 10.8s -182ms
nodeModulesSize 83 MB 83 MB ⚠️ +279 B
Client Bundles (main, webpack, commons)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
677f882d2ed8..6cec.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3b46b61..4d69.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-1a1f628..eeb5.js gzip 1.61 kB 1.61 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary prateekbh/next.js fix-fontfallback Change
_error.js 1 MB 1 MB ⚠️ +94 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +94 B
link.js 1.06 MB 1.06 MB ⚠️ +94 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +94 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +94 B
Overall change 5.17 MB 5.17 MB ⚠️ +470 B
Commit: 5a46661

@kodiakhq kodiakhq bot merged commit 16e9de3 into vercel:canary Dec 30, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server logging "The postprocess middleware "Inline-Fonts" took 11ms(10, 1) to complete" using 10.0.4-canary.8
3 participants
@prateekbh @ijjk @Timer