Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README for with-emotion example #20338

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Update README for with-emotion example #20338

merged 3 commits into from
Dec 28, 2020

Conversation

xiaooye
Copy link
Contributor

@xiaooye xiaooye commented Dec 19, 2020

Change README from outdated @emotion/core to @emotion/react

@xiaooye
Update README for with-emotion example
52311e6 
Change README from outdated @emotion/core to @emotion/react
@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 19, 2020
@vercel vercel bot temporarily deployed to Preview December 19, 2020 23:17 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 19, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary xiaooye/next.js canary Change
buildDuration 11.3s 11.2s -55ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary xiaooye/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.774 2.783 ⚠️ +0.01
/ avg req/sec 901.24 898.27 ⚠️ -2.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.712 1.656 -0.06
/error-in-render avg req/sec 1460.18 1510.06 +49.88
Client Bundles (main, webpack, commons)
vercel/next.js canary xiaooye/next.js canary Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary xiaooye/next.js canary Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary xiaooye/next.js canary Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary xiaooye/next.js canary Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary xiaooye/next.js canary Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary xiaooye/next.js canary Change
buildDuration 13.2s 13.1s -53ms
nodeModulesSize 82.4 MB 82.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary xiaooye/next.js canary Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f21dcf..0011.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary xiaooye/next.js canary Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary xiaooye/next.js canary Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary xiaooye/next.js canary Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary xiaooye/next.js canary Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 52311e6

lfades
lfades approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@vercel vercel bot temporarily deployed to Preview December 22, 2020 03:38 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 22, 2020

Failing test suites

Commit: 70de9ad

test/integration/custom-routes-i18n/test/index.test.js

  • Custom routes i18n > dev mode > should navigate on the client with rewrites correctly
Expand output

● Custom routes i18n › dev mode › should navigate on the client with rewrites correctly

TIMED OUT: success

undefined

  384 | 
  385 |   if (hardError) {
> 386 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  387 |   }
  388 |   return false
  389 | }

  at check (lib/next-test-utils.js:386:11)
  at Object.<anonymous> (integration/custom-routes-i18n/test/index.test.js:110:7)

@ijjk
Copy link
Member

ijjk commented Dec 22, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary xiaooye/next.js canary Change
buildDuration 10.1s 10s -160ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary xiaooye/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.009 2.02 ⚠️ +0.01
/ avg req/sec 1244.19 1237.47 ⚠️ -6.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.21 1.283 ⚠️ +0.07
/error-in-render avg req/sec 2065.93 1948.26 ⚠️ -117.67
Client Bundles (main, webpack, commons)
vercel/next.js canary xiaooye/next.js canary Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-72193d1..1356.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary xiaooye/next.js canary Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary xiaooye/next.js canary Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary xiaooye/next.js canary Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary xiaooye/next.js canary Change
index.html gzip 613 B 613 B ✓
link.html gzip 618 B 618 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary xiaooye/next.js canary Change
buildDuration 12.1s 11.9s -180ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary xiaooye/next.js canary Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-72193d1..1356.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary xiaooye/next.js canary Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary xiaooye/next.js canary Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary xiaooye/next.js canary Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary xiaooye/next.js canary Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 70de9ad

@vercel vercel bot temporarily deployed to Preview December 28, 2020 16:13 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary xiaooye/next.js canary Change
buildDuration 10.2s 10s -167ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary xiaooye/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.17 2.107 -0.06
/ avg req/sec 1151.93 1186.3 +34.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.496 1.489 -0.01
/error-in-render avg req/sec 1671.14 1678.66 +7.52
Client Bundles (main, webpack, commons)
vercel/next.js canary xiaooye/next.js canary Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary xiaooye/next.js canary Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary xiaooye/next.js canary Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary xiaooye/next.js canary Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary xiaooye/next.js canary Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary xiaooye/next.js canary Change
buildDuration 12.2s 11.7s -482ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary xiaooye/next.js canary Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary xiaooye/next.js canary Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary xiaooye/next.js canary Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary xiaooye/next.js canary Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary xiaooye/next.js canary Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 32c8364

@kodiakhq kodiakhq bot merged commit e87b05f into vercel:canary Dec 28, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lachlanjc lachlanjc lachlanjc approved these changes

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiaooye @ijjk @lfades @lachlanjc @Timer