Upgrade microbundle in next-polyfill-* packages #18926

BasixKOR · 2020-11-07T14:38:51Z

This PR upgrades microbundle used in polyfill packages to newer versions.

ijjk · 2020-11-07T14:48:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	13.7s	13.9s	⚠️ +244ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +143 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.606	2.635	⚠️ +0.03
/ avg req/sec	959.18	948.8	⚠️ -10.38
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.579	1.668	⚠️ +0.09
/error-in-render avg req/sec	1583.77	1498.45	⚠️ -85.32

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d942eb5..343f.js gzip	7.4 kB	7.4 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-34e64ff..dule.js gzip	6.39 kB	6.39 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	31.1 kB	⚠️ +111 B
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-8a9d104..0e42.js gzip	1.55 kB	1.55 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.96 kB	7.96 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-d1cfb87..dule.js gzip	1.49 kB	1.49 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.59 kB	5.59 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	-2 B
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3 kB	-2 B

Diffs

Diff for polyfills-f7..972ef83e9.js

failed to diff

Diff for index.html

@@ -82,7 +82,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Diff for link.html

@@ -87,7 +87,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Diff for withRouter.html

@@ -82,7 +82,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	15.2s	15.7s	⚠️ +490ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +143 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d942eb5..343f.js gzip	7.4 kB	7.4 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-34e64ff..dule.js gzip	6.39 kB	6.39 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	N/A	N/A
polyfills-eb..5db0.js gzip	N/A	31.1 kB	N/A
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-8a9d104..0e42.js gzip	1.55 kB	1.55 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.96 kB	7.96 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-d1cfb87..dule.js gzip	1.49 kB	1.49 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.59 kB	5.59 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_error.js	915 kB	915 kB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	915 kB	915 kB	✓
link.js	964 kB	964 kB	✓
routerDirect.js	957 kB	957 kB	✓
withRouter.js	957 kB	957 kB	✓
Overall change	4.72 MB	4.72 MB	✓

Commit: 623d512

ijjk · 2020-11-07T14:51:21Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	12.8s	13s	⚠️ +136ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +143 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.452	2.507	⚠️ +0.06
/ avg req/sec	1019.67	997.23	⚠️ -22.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.48	1.43	-0.05
/error-in-render avg req/sec	1688.7	1748.3	+59.6

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d942eb5..343f.js gzip	7.4 kB	7.4 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-34e64ff..dule.js gzip	6.39 kB	6.39 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	31.1 kB	⚠️ +111 B
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-8a9d104..0e42.js gzip	1.55 kB	1.55 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.96 kB	7.96 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-d1cfb87..dule.js gzip	1.49 kB	1.49 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.59 kB	5.59 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	-2 B
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3 kB	-2 B

Diffs

Diff for polyfills-f7..972ef83e9.js

failed to diff

Diff for index.html

@@ -82,7 +82,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Diff for link.html

@@ -87,7 +87,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Diff for withRouter.html

@@ -82,7 +82,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	14.4s	14.3s	-67ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +143 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d942eb5..343f.js gzip	7.4 kB	7.4 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-34e64ff..dule.js gzip	6.39 kB	6.39 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	N/A	N/A
polyfills-eb..5db0.js gzip	N/A	31.1 kB	N/A
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-8a9d104..0e42.js gzip	1.55 kB	1.55 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.96 kB	7.96 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-d1cfb87..dule.js gzip	1.49 kB	1.49 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.59 kB	5.59 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_error.js	915 kB	915 kB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	915 kB	915 kB	✓
link.js	964 kB	964 kB	✓
routerDirect.js	957 kB	957 kB	✓
withRouter.js	957 kB	957 kB	✓
Overall change	4.72 MB	4.72 MB	✓

Commit: 088fe4d

ijjk · 2020-11-07T15:26:26Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	11.2s	10.9s	-272ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +143 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.126	2.031	-0.09
/ avg req/sec	1175.66	1231.21	+55.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.113	1.094	-0.02
/error-in-render avg req/sec	2246.23	2284.95	+38.72

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d942eb5..343f.js gzip	7.4 kB	7.4 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-34e64ff..dule.js gzip	6.39 kB	6.39 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	31.1 kB	⚠️ +111 B
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-8a9d104..0e42.js gzip	1.55 kB	1.55 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.96 kB	7.96 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-d1cfb87..dule.js gzip	1.49 kB	1.49 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.59 kB	5.59 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	-2 B
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3 kB	-2 B

Diffs

Diff for polyfills-f7..972ef83e9.js

failed to diff

Diff for index.html

@@ -82,7 +82,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Diff for link.html

@@ -87,7 +87,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Diff for withRouter.html

@@ -82,7 +82,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	12.4s	12.2s	-224ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +143 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..7d3b.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d942eb5..343f.js gzip	7.4 kB	7.4 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.4 kB	58.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	7.04 kB	7.04 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-34e64ff..dule.js gzip	6.39 kB	6.39 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	N/A	N/A
polyfills-eb..5db0.js gzip	N/A	31.1 kB	N/A
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-fca3d..2eb1.js gzip	3.44 kB	3.44 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-8a9d104..0e42.js gzip	1.55 kB	1.55 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.96 kB	7.96 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-d1cfb87..dule.js gzip	1.49 kB	1.49 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.59 kB	5.59 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_error.js	915 kB	915 kB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	915 kB	915 kB	✓
link.js	964 kB	964 kB	✓
routerDirect.js	957 kB	957 kB	✓
withRouter.js	957 kB	957 kB	✓
Overall change	4.72 MB	4.72 MB	✓

Commit: f35903b

BasixKOR · 2020-11-07T15:42:58Z

I'm unsure what should I do about the Check Pre-compiled check (I'm new here). Would love to get some advice!

ludofischer · 2020-11-11T19:12:01Z

You need to commit the files about which it complains 'changes not staged for commit'. In this case

packages/next/compiled/babel/bundle.js
packages/next/compiled/find-cache-dir/index.js

Next has a somewhat unusual build process. Some dependencies are not retrieved from node_modules directly. Instead, the ncc tool more or less concatenates every file in the package and puts the result in the compiled directory. So to ensure Next really uses the updated dependencies, every time you change a dependency you need to rebuild the whole thing, and add the precompiled directories to your commit.

By the way, this update would be handy to avoid having to install Python 2 just to build Next on Node 14. Right now microbundle requires an old version of the iltorb compression library which uses node-gyp, has no prebuilt versions for Node 14 and requires Python 2 (which is not included any more by default in some Linux distributions) to compile.

BasixKOR · 2020-11-11T23:47:28Z

Yeah, looks like you already know how did I get here 😂 I'll commit those soon!

ijjk · 2020-11-12T00:42:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	15s	15.4s	⚠️ +408ms
nodeModulesSize	84.8 MB	84.8 MB	⚠️ +126 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.815	2.819	0
/ avg req/sec	888.25	886.97	⚠️ -1.28
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.772	1.718	-0.05
/error-in-render avg req/sec	1410.64	1455.48	+44.84

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..3c49.js gzip	12.6 kB	12.6 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-15d43b2..eae1.js gzip	6.48 kB	6.48 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.8 kB	58.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	8.22 kB	8.22 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-351dac8..dule.js gzip	5.58 kB	5.58 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.5 kB	53.5 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	31.1 kB	⚠️ +111 B
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d9a15a0..130a.js gzip	1.57 kB	1.57 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.98 kB	7.98 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-973cce3..dule.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.6 kB	5.6 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
index.html gzip	970 B	968 B	-2 B
link.html gzip	975 B	975 B	✓
withRouter.html gzip	963 B	962 B	-1 B
Overall change	2.91 kB	2.9 kB	-3 B

Diffs

Diff for polyfills-f7..972ef83e9.js

failed to diff

Diff for index.html

@@ -79,7 +79,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-7fca611961c91644590f.js"

Diff for link.html

@@ -84,7 +84,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-7fca611961c91644590f.js"

Diff for withRouter.html

@@ -79,7 +79,7 @@
     <script
       crossorigin="anonymous"
       nomodule=""
-      src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
+      src="/_next/static/chunks/polyfills-7dab015cef8c8f016afa.js"
     ></script>
     <script
       src="/_next/static/chunks/main-7fca611961c91644590f.js"

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
buildDuration	17.3s	17.2s	-96ms
nodeModulesSize	84.8 MB	84.8 MB	⚠️ +126 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..3c49.js gzip	12.6 kB	12.6 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-15d43b2..eae1.js gzip	6.48 kB	6.48 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.8 kB	58.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
677f882d2ed8..dule.js gzip	8.22 kB	8.22 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-351dac8..dule.js gzip	5.58 kB	5.58 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.5 kB	53.5 kB	✓

Legacy Client Bundles (polyfills) Overall increase ⚠️

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
polyfills-4b..e242.js gzip	31 kB	N/A	N/A
polyfills-eb..5db0.js gzip	N/A	31.1 kB	N/A
Overall change	31 kB	31.1 kB	⚠️ +111 B

Client Pages

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d9a15a0..130a.js gzip	1.57 kB	1.57 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.98 kB	7.98 kB	✓

Client Pages Modern

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-973cce3..dule.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.6 kB	5.6 kB	✓

Client Build Manifests

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	BasixKOR/next.js polyfill-microbundle-up	Change
_error.js	916 kB	916 kB	✓
404.html	4.61 kB	4.61 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	916 kB	916 kB	✓
link.js	974 kB	974 kB	✓
routerDirect.js	967 kB	967 kB	✓
withRouter.js	967 kB	967 kB	✓
Overall change	4.75 MB	4.75 MB	✓

Commit: 09c242a

ijjk · 2020-11-12T00:48:55Z

Failing test suites

Commit: 09c242a

test/integration/size-limit/test/index.test.js

Production response size > should not increase the overall response size of default build

Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 1024
Received:    1264

  82 |     // These numbers are without gzip compression!
  83 |     const delta = responseSizesBytes - 282 * 1024
> 84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
     |                   ^
  85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
  86 |   })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

BasixKOR · 2020-11-14T10:28:26Z

I expected the tests will be triggered eventually but apparently it isn't, is it okay to trigger them by an empty commit?

ludofischer · 2020-11-14T17:54:14Z

I am not a maintainer here, so my words about correct CI usage carry limited weight, but I notice a failing test: test/integration/size-limit/test/index.test.js. Did the microbundle update cause a bundle size increase? This PR would be more convincing, if either the test passed or the reason it doesn't was known.
I noticed a second issue. In the diff the babel bundle for the main next package changed: packages/next/compiled/babel/bundle.js. I would expect only the dev dependencies of the polyfill* package should change, and not the babel version in the next package. Try yarn why babel could give some idea, also looking at the taskr files in packages/next can give an idea of where the precompiled bundles are coming from.

ludofischer · 2020-12-22T22:27:29Z

Hi, since microbundle 0.13 has been released I’ve opened a new pull request to update microbundle: #20406 I hope there won’t be any strange test failures (I wonder whether the microbundle version in this pull request really causes a compiled size regression as the tests imply?)

Fixes #20585 Closes #20406 as it duplicates Babel dependencies Closes #18926 as it's outdated

Upgrade microbundle in next-polyfill-* packages

f35903b

BasixKOR force-pushed the polyfill-microbundle-up branch from 088fe4d to f35903b Compare November 7, 2020 15:18

BasixKOR marked this pull request as ready for review November 7, 2020 15:41

BasixKOR requested review from ijjk, lfades, Timer and timneutkens as code owners November 7, 2020 15:41

ijjk added the type: next label Nov 12, 2020

Update precomiled files

c57fb96

BasixKOR force-pushed the polyfill-microbundle-up branch from 09c242a to c57fb96 Compare November 12, 2020 11:29

ludofischer mentioned this pull request Dec 22, 2020

Upgrade microbundle in next-polyfill-module to 0.13 #20406

Closed

Timer mentioned this pull request Dec 29, 2020

deps: upgrade various deps (mainly babel) #20586

Merged

kodiakhq bot closed this in #20586 Dec 29, 2020

kodiakhq bot pushed a commit that referenced this pull request Dec 29, 2020

deps: upgrade various deps (mainly babel) (#20586)

61e7dea

Fixes #20585 Closes #20406 as it duplicates Babel dependencies Closes #18926 as it's outdated

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade microbundle in next-polyfill-* packages #18926

Upgrade microbundle in next-polyfill-* packages #18926

BasixKOR commented Nov 7, 2020

ijjk commented Nov 7, 2020

Diffs

ijjk commented Nov 7, 2020

Diffs

ijjk commented Nov 7, 2020

Diffs

BasixKOR commented Nov 7, 2020

ludofischer commented Nov 11, 2020

BasixKOR commented Nov 11, 2020

ijjk commented Nov 12, 2020

Diffs

ijjk commented Nov 12, 2020

BasixKOR commented Nov 14, 2020 •

edited

Loading

ludofischer commented Nov 14, 2020

ludofischer commented Dec 22, 2020

Upgrade microbundle in next-polyfill-* packages #18926

Upgrade microbundle in next-polyfill-* packages #18926

Conversation

BasixKOR commented Nov 7, 2020

ijjk commented Nov 7, 2020

Stats from current PR

Diffs

ijjk commented Nov 7, 2020

Stats from current PR

Diffs

ijjk commented Nov 7, 2020

Stats from current PR

Diffs

BasixKOR commented Nov 7, 2020

ludofischer commented Nov 11, 2020

BasixKOR commented Nov 11, 2020

ijjk commented Nov 12, 2020

Stats from current PR

Diffs

ijjk commented Nov 12, 2020

Failing test suites

BasixKOR commented Nov 14, 2020 • edited Loading

ludofischer commented Nov 14, 2020

ludofischer commented Dec 22, 2020

BasixKOR commented Nov 14, 2020 •

edited

Loading