Added `file:` as valid protocol #18081

alirezavalizade · 2020-10-21T10:14:04Z

Next.js navigation doesn't work on electron based applications, After reading the code I found that only http: and https: are the valid protocols for parsing url.

…nto canary

ijjk · 2020-10-21T10:23:57Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
buildDuration	12.8s	12.8s	⚠️ +48ms
nodeModulesSize	62.5 MB	62.5 MB	⚠️ +289 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.401	2.332	-0.07
/ avg req/sec	1041.14	1072.07	+30.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.284	1.313	⚠️ +0.03
/error-in-render avg req/sec	1946.37	1903.8	⚠️ -42.57

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
677f882d2ed8..35e7.js gzip	11.1 kB	11.1 kB	⚠️ +14 B
framework.HASH.js gzip	39 kB	39 kB	✓
main-0297b89..3d55.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.2 kB	⚠️ +14 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.96 kB	⚠️ +15 B
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8539e6d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	⚠️ +15 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	alirezavalizade/next.js canary	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	alirezavalizade/next.js canary	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	994 B	-2 B
Overall change	3.01 kB	3.01 kB	-2 B

Diffs

Diff for 677f882d2ed8..d3.module.js

@@ -1865,6 +1865,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       var _querystring = __webpack_require__("3WeD");
 
+      var PROTOCOLS = ["http:", "https:", "file:"];
       var DUMMY_BASE = new URL(
         false ? undefined : (0, _utils.getLocationOrigin)()
       );
@@ -1886,11 +1887,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           origin,
           protocol
         } = new URL(url, resolvedBase);
+        var hasValidProtocol = PROTOCOLS.includes(protocol);
 
-        if (
-          origin !== DUMMY_BASE.origin ||
-          (protocol !== "http:" && protocol !== "https:")
-        ) {
+        if (origin !== DUMMY_BASE.origin || !hasValidProtocol) {
           throw new Error("invariant: invalid relative URL");
         }

Diff for 677f882d2ed8..5b45de20a.js

@@ -2603,6 +2603,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
       var _querystring = __webpack_require__("3WeD");
 
+      var PROTOCOLS = ["http:", "https:", "file:"];
       var DUMMY_BASE = new URL(
         false ? undefined : (0, _utils.getLocationOrigin)()
       );
@@ -2625,10 +2626,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           origin = _URL.origin,
           protocol = _URL.protocol;
 
-        if (
-          origin !== DUMMY_BASE.origin ||
-          (protocol !== "http:" && protocol !== "https:")
-        ) {
+        var hasValidProtocol = PROTOCOLS.includes(protocol);
+
+        if (origin !== DUMMY_BASE.origin || !hasValidProtocol) {
           throw new Error("invariant: invalid relative URL");
         }

Diff for index.html

@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.15d98acc7b022abf75d3.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.91f969384632ee70cd72.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1f665b9cff05b45de20a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9377826da610a1180c18.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.15d98acc7b022abf75d3.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.91f969384632ee70cd72.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Diff for link.html

@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.15d98acc7b022abf75d3.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.91f969384632ee70cd72.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -126,13 +126,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1f665b9cff05b45de20a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9377826da610a1180c18.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.15d98acc7b022abf75d3.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.91f969384632ee70cd72.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Diff for withRouter.html

@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.15d98acc7b022abf75d3.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.91f969384632ee70cd72.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1f665b9cff05b45de20a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9377826da610a1180c18.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.15d98acc7b022abf75d3.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.91f969384632ee70cd72.module.js"
       async=""
       crossorigin="anonymous"
       type="module"

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
buildDuration	14.4s	14.3s	-81ms
nodeModulesSize	62.5 MB	62.5 MB	⚠️ +289 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
677f882d2ed8..35e7.js gzip	11.1 kB	N/A	N/A
framework.HASH.js gzip	39 kB	39 kB	✓
main-0297b89..3d55.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
677f882d2ed8..360e.js gzip	N/A	11.1 kB	N/A
Overall change	58.1 kB	58.2 kB	⚠️ +14 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
677f882d2ed8..dule.js gzip	6.94 kB	N/A	N/A
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8539e6d..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
677f882d2ed8..dule.js gzip	N/A	6.96 kB	N/A
Overall change	53 kB	53 kB	⚠️ +15 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	alirezavalizade/next.js canary	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	alirezavalizade/next.js canary	Change
_error.js	1.06 MB	1.06 MB	⚠️ +77 B
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	⚠️ +77 B
link.js	1.1 MB	1.1 MB	⚠️ +77 B
routerDirect.js	1.1 MB	1.1 MB	⚠️ +77 B
withRouter.js	1.1 MB	1.1 MB	⚠️ +77 B
Overall change	5.42 MB	5.42 MB	⚠️ +385 B

Commit: 32abf2a

timneutkens · 2020-10-21T10:24:00Z

This is the same as #17216 and #16650. The main problem being these changes need integration tests. #16650 has them but has a merge conflict and some discussion going on still.

timneutkens · 2020-11-13T09:13:20Z

Closing as #16650 was landed, thanks for the PR!

alirezavalizade added 2 commits October 21, 2020 12:10

Added 'file:' as a valid protocol

cf0aa21

Merge branch 'canary' of https://github.com/alirezavalizade/next.js i…

32abf2a

…nto canary

alirezavalizade requested review from ijjk, lfades, Timer and timneutkens as code owners October 21, 2020 10:14

ijjk added the type: next label Oct 21, 2020

timneutkens closed this Nov 13, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `file:` as valid protocol #18081

Added `file:` as valid protocol #18081

alirezavalizade commented Oct 21, 2020

ijjk commented Oct 21, 2020

Diffs

timneutkens commented Oct 21, 2020

timneutkens commented Nov 13, 2020

Added file: as valid protocol #18081

Added file: as valid protocol #18081

Conversation

alirezavalizade commented Oct 21, 2020

ijjk commented Oct 21, 2020

Stats from current PR

Diffs

timneutkens commented Oct 21, 2020

timneutkens commented Nov 13, 2020

Added `file:` as valid protocol #18081

Added `file:` as valid protocol #18081