Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #top anchor link scroll #16638

Merged
merged 9 commits into from
Jan 30, 2021
Merged

Fix #top anchor link scroll #16638

merged 9 commits into from
Jan 30, 2021

Conversation

lebreRafael
Copy link
Contributor

According to MDN docs the page must scroll to the top with both "#" and "#top" anchors.

Screen Shot 2020-08-27 at 7 20 19 PM

@ijjk
Copy link
Member

ijjk commented Aug 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.9s 13.2s ⚠️ +335ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.308 2.33 ⚠️ +0.02
/ avg req/sec 1083.23 1073.08 ⚠️ -10.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.313 1.331 ⚠️ +0.02
/error-in-render avg req/sec 1904.66 1878.94 ⚠️ -25.72
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ⚠️ +6 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..dule.js gzip 6.15 kB 6.16 kB ⚠️ +7 B
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.42 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 963 B -1 B
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for 677f882d2ed8..6e297704b.js 
@@ -1771,9 +1771,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for 677f882d2ed8..29.module.js 
@@ -1265,9 +1265,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         }
 
         scrollToHash(as) {
-          var [, hash] = as.split("#"); // Scroll to top if the hash is just `#` with no value
+          var [, hash] = as.split("#"); // Scroll to top if the hash is just `#` with no value or `#top`
+          // To mirror browsers
 
-          if (hash === "") {
+          if (hash === "" || hash === "top") {
             window.scrollTo(0, 0);
             return;
           } // First we check if the element by id is found
Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a784ea5f783938acccff.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0cdea1ce21abef1d1346.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a784ea5f783938acccff.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a784ea5f783938acccff.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0cdea1ce21abef1d1346.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a784ea5f783938acccff.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a784ea5f783938acccff.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0cdea1ce21abef1d1346.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a784ea5f783938acccff.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 14.6s 14.5s -91ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..7f47.js gzip 10.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..1138.js gzip N/A 10.3 kB N/A
Overall change 57.4 kB 57.4 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..dule.js gzip 6.15 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.42 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 6.16 kB N/A
Overall change 52.3 kB 52.3 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ⚠️ +54 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +54 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +54 B
Overall change 5.28 MB 5.28 MB ⚠️ +162 B
Commit: 7fd0807

Timer
Timer requested changes Aug 30, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for this!

@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.8s 13.9s ⚠️ +1.1s
nodeModulesSize 56.8 MB 56.8 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.332 2.53 ⚠️ +0.2
/ avg req/sec 1071.86 988.05 ⚠️ -83.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.414 1.52 ⚠️ +0.11
/error-in-render avg req/sec 1767.99 1644.22 ⚠️ -123.77
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ⚠️ +6 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ⚠️ +7 B
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-99715b4..dule.js gzip 6.4 kB 6.4 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.3 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 971 B 971 B ✓
link.html gzip 977 B 978 B ⚠️ +1 B
withRouter.html gzip 964 B 963 B -1 B
Overall change 2.91 kB 2.91 kB ✓

Diffs

Diff for 677f882d2ed8..60.module.js 
@@ -1253,9 +1253,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         }
 
         scrollToHash(as) {
-          var [, hash] = as.split("#"); // Scroll to top if the hash is just `#` with no value
+          var [, hash] = as.split("#"); // Scroll to top if the hash is just `#` with no value or `#top`
+          // To mirror browsers
 
-          if (hash === "") {
+          if (hash === "" || hash === "top") {
             window.scrollTo(0, 0);
             return;
           } // First we check if the element by id is found
Diff for 677f882d2ed8..886051899.js 
@@ -1753,9 +1753,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2206d208af7e83206260.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2fb7e6e8d2d45e0ed651.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b1af6078fa6886051899.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.fe202242227967a4d677.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2206d208af7e83206260.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2fb7e6e8d2d45e0ed651.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2206d208af7e83206260.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2fb7e6e8d2d45e0ed651.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b1af6078fa6886051899.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.fe202242227967a4d677.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2206d208af7e83206260.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2fb7e6e8d2d45e0ed651.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2206d208af7e83206260.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2fb7e6e8d2d45e0ed651.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b1af6078fa6886051899.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.fe202242227967a4d677.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2206d208af7e83206260.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2fb7e6e8d2d45e0ed651.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 14.7s 15s ⚠️ +224ms
nodeModulesSize 56.8 MB 56.8 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..f20b.js gzip 10.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..5cc7.js gzip N/A 10.3 kB N/A
Overall change 57.3 kB 57.3 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..dule.js gzip 6.13 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-99715b4..dule.js gzip 6.4 kB 6.4 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 6.13 kB N/A
Overall change 52.2 kB 52.3 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ⚠️ +54 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +54 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +54 B
Overall change 5.28 MB 5.28 MB ⚠️ +162 B
Commit: f2dbd6a

@lebreRafael lebreRafael requested a review from Timer September 2, 2020 12:31
@lebreRafael
Copy link
Contributor Author

@Timer do you need something else for this PR?

@ijjk
Copy link
Member

ijjk commented Sep 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.5s 12.5s -1ms
nodeModulesSize 62.9 MB 62.9 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.379 2.429 ⚠️ +0.05
/ avg req/sec 1050.69 1029.23 ⚠️ -21.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.432 1.431 0
/error-in-render avg req/sec 1746.32 1747.52 +1.2
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ⚠️ +6 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ⚠️ +7 B
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 1 kB 1 kB ⚠️ +1 B
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 997 B 995 B -2 B
Overall change 3.01 kB 3.01 kB -1 B

Diffs

Diff for 677f882d2ed8..5fa35cac6.js 
@@ -1955,9 +1955,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for 677f882d2ed8..aa.module.js 
@@ -1414,9 +1414,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         }
 
         scrollToHash(as) {
-          var [, hash] = as.split("#"); // Scroll to top if the hash is just `#` with no value
+          var [, hash] = as.split("#"); // Scroll to top if the hash is just `#` with no value or `#top`
+          // To mirror browsers
 
-          if (hash === "") {
+          if (hash === "" || hash === "top") {
             window.scrollTo(0, 0);
             return;
           } // First we check if the element by id is found
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ed82f38c7a1994b728aa.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.57f0b757e58e6701a695.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2730f3273c05fa35cac6.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5c9442f6628ae6c3a1db.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ed82f38c7a1994b728aa.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.57f0b757e58e6701a695.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ed82f38c7a1994b728aa.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.57f0b757e58e6701a695.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -126,13 +126,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2730f3273c05fa35cac6.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5c9442f6628ae6c3a1db.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ed82f38c7a1994b728aa.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.57f0b757e58e6701a695.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ed82f38c7a1994b728aa.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.57f0b757e58e6701a695.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.2730f3273c05fa35cac6.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5c9442f6628ae6c3a1db.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ed82f38c7a1994b728aa.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.57f0b757e58e6701a695.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 13.9s 13.4s -525ms
nodeModulesSize 62.9 MB 62.9 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..9339.js gzip 10.9 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..8efa.js gzip N/A 10.9 kB N/A
Overall change 57.8 kB 57.8 kB ⚠️ +6 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..dule.js gzip 6.77 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 6.77 kB N/A
Overall change 52.7 kB 52.7 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1.04 MB 1.04 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ⚠️ +54 B
routerDirect.js 1.08 MB 1.08 MB ⚠️ +54 B
withRouter.js 1.08 MB 1.08 MB ⚠️ +54 B
Overall change 5.31 MB 5.31 MB ⚠️ +162 B
Commit: cea3c8e

lfades
lfades previously approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @lebreRafael

timneutkens
timneutkens previously approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to land, thanks!

@ijjk
Copy link
Member

ijjk commented Jan 23, 2021

Failing test suites

Commit: 59dc2ee

test/integration/build-output/test/index.test.js

  • Build Output > Basic Application Output > should not deviate from snapshot
Expand output

● Build Output › Basic Application Output › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 63.5
Received: 63.6

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.10000000000000142

  105 |       expect(err404FirstLoad.endsWith('kB')).toBe(true)
  106 | 
> 107 |       expect(parseFloat(sharedByAll)).toBeCloseTo(63.5, 1)
      |                                       ^
  108 |       expect(sharedByAll.endsWith('kB')).toBe(true)
  109 | 
  110 |       if (_appSize.endsWith('kB')) {

  at Object.<anonymous> (integration/build-output/test/index.test.js:107:39)

@ijjk
Copy link
Member

ijjk commented Jan 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 10.4s 10.4s ⚠️ +21ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +129 B
Page Load Tests Overall increase ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.08 2.049 -0.03
/ avg req/sec 1201.83 1220.02 +18.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.368 1.268 -0.1
/error-in-render avg req/sec 1827.18 1972.02 +144.84
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ⚠️ +5 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 619 B -1 B
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB -1 B

Diffs

Diff for 677f882d2ed8..dde534236.js 
@@ -2840,9 +2840,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.2s 12.4s ⚠️ +136ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..49c4.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ⚠️ +54 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +54 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +54 B
Overall change 5.19 MB 5.19 MB ⚠️ +162 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.5s 12.4s -32ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.998 2.082 ⚠️ +0.08
/ avg req/sec 1251.14 1200.93 ⚠️ -50.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.301 1.334 ⚠️ +0.03
/error-in-render avg req/sec 1921.36 1874.75 ⚠️ -46.61
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
597-c48889ef..1870.js gzip 13 kB 13 kB ⚠️ +7 B
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.9 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 588 B 587 B -1 B
link.html gzip 593 B 592 B -1 B
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB -2 B

Diffs

Diff for 677f882d2ed8..c23f838ed.js 
@@ -1654,7 +1654,7 @@
               value: function(t) {
                 var e = t.split("#"),
                   r = u(e, 2)[1];
-                if ("" !== r) {
+                if ("" !== r && "top" !== r) {
                   var n = document.getElementById(r);
                   if (n) n.scrollIntoView();
                   else {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "J9emQ3T_zu0QHp1vnfFoB",
+        "buildId": "oLeAW10xUwT-Mph1qnFDD",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J9emQ3T_zu0QHp1vnfFoB/_buildManifest.js"
+      src="/_next/static/oLeAW10xUwT-Mph1qnFDD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J9emQ3T_zu0QHp1vnfFoB/_ssgManifest.js"
+      src="/_next/static/oLeAW10xUwT-Mph1qnFDD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "J9emQ3T_zu0QHp1vnfFoB",
+        "buildId": "oLeAW10xUwT-Mph1qnFDD",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J9emQ3T_zu0QHp1vnfFoB/_buildManifest.js"
+      src="/_next/static/oLeAW10xUwT-Mph1qnFDD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J9emQ3T_zu0QHp1vnfFoB/_ssgManifest.js"
+      src="/_next/static/oLeAW10xUwT-Mph1qnFDD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "J9emQ3T_zu0QHp1vnfFoB",
+        "buildId": "oLeAW10xUwT-Mph1qnFDD",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J9emQ3T_zu0QHp1vnfFoB/_buildManifest.js"
+      src="/_next/static/oLeAW10xUwT-Mph1qnFDD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J9emQ3T_zu0QHp1vnfFoB/_ssgManifest.js"
+      src="/_next/static/oLeAW10xUwT-Mph1qnFDD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 59dc2ee

Timer
Timer previously approved these changes Jan 25, 2021
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Failing test suites

Commit: 55ba2df

test/integration/build-output/test/index.test.js

  • Build Output > Basic Application Output > should not deviate from snapshot
Expand output

● Build Output › Basic Application Output › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 63.5
Received: 63.6

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.10000000000000142

  105 |       expect(err404FirstLoad.endsWith('kB')).toBe(true)
  106 | 
> 107 |       expect(parseFloat(sharedByAll)).toBeCloseTo(63.5, 1)
      |                                       ^
  108 |       expect(sharedByAll.endsWith('kB')).toBe(true)
  109 | 
  110 |       if (_appSize.endsWith('kB')) {

  at Object.<anonymous> (integration/build-output/test/index.test.js:107:39)

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 9.7s 9.7s -5ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.924 2.026 ⚠️ +0.1
/ avg req/sec 1299.08 1233.93 ⚠️ -65.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.23 1.21 -0.02
/error-in-render avg req/sec 2031.96 2066.2 +34.24
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ⚠️ +5 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 619 B -1 B
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB -1 B

Diffs

Diff for 677f882d2ed8..dde534236.js 
@@ -2840,9 +2840,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 11.6s 11.7s ⚠️ +160ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..49c4.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ⚠️ +54 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +54 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +54 B
Overall change 5.19 MB 5.19 MB ⚠️ +162 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.1s 11.6s -421ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +129 B
Page Load Tests Overall increase ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.958 1.87 -0.09
/ avg req/sec 1276.76 1337.15 +60.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.237 1.217 -0.02
/error-in-render avg req/sec 2021.09 2053.64 +32.55
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
597-c48889ef..1870.js gzip 13 kB 13 kB ⚠️ +7 B
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.9 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 587 B 586 B -1 B
link.html gzip 591 B 593 B ⚠️ +2 B
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ⚠️ +1 B

Diffs

Diff for 677f882d2ed8..c23f838ed.js 
@@ -1654,7 +1654,7 @@
               value: function(t) {
                 var e = t.split("#"),
                   r = u(e, 2)[1];
-                if ("" !== r) {
+                if ("" !== r && "top" !== r) {
                   var n = document.getElementById(r);
                   if (n) n.scrollIntoView();
                   else {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "o1lDxDgSfHhQxSOIBwoiq",
+        "buildId": "SrnCWZhAUINkYqPsT9qk2",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/o1lDxDgSfHhQxSOIBwoiq/_buildManifest.js"
+      src="/_next/static/SrnCWZhAUINkYqPsT9qk2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/o1lDxDgSfHhQxSOIBwoiq/_ssgManifest.js"
+      src="/_next/static/SrnCWZhAUINkYqPsT9qk2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "o1lDxDgSfHhQxSOIBwoiq",
+        "buildId": "SrnCWZhAUINkYqPsT9qk2",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/o1lDxDgSfHhQxSOIBwoiq/_buildManifest.js"
+      src="/_next/static/SrnCWZhAUINkYqPsT9qk2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/o1lDxDgSfHhQxSOIBwoiq/_ssgManifest.js"
+      src="/_next/static/SrnCWZhAUINkYqPsT9qk2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "o1lDxDgSfHhQxSOIBwoiq",
+        "buildId": "SrnCWZhAUINkYqPsT9qk2",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/o1lDxDgSfHhQxSOIBwoiq/_buildManifest.js"
+      src="/_next/static/SrnCWZhAUINkYqPsT9qk2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/o1lDxDgSfHhQxSOIBwoiq/_ssgManifest.js"
+      src="/_next/static/SrnCWZhAUINkYqPsT9qk2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 55ba2df

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Failing test suites

Commit: f6961fe

test/integration/build-output/test/index.test.js

  • Build Output > Basic Application Output > should not deviate from snapshot
Expand output

● Build Output › Basic Application Output › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 63.5
Received: 63.6

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.10000000000000142

  105 |       expect(err404FirstLoad.endsWith('kB')).toBe(true)
  106 | 
> 107 |       expect(parseFloat(sharedByAll)).toBeCloseTo(63.5, 1)
      |                                       ^
  108 |       expect(sharedByAll.endsWith('kB')).toBe(true)
  109 | 
  110 |       if (_appSize.endsWith('kB')) {

  at Object.<anonymous> (integration/build-output/test/index.test.js:107:39)

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 10.4s 10.1s -269ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.011 2.022 ⚠️ +0.01
/ avg req/sec 1242.93 1236.22 ⚠️ -6.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.272 1.277 0
/error-in-render avg req/sec 1965.97 1957.46 ⚠️ -8.51
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ⚠️ +5 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 619 B -1 B
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB -1 B

Diffs

Diff for 677f882d2ed8..dde534236.js 
@@ -2840,9 +2840,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12s 11.9s -68ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..49c4.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ⚠️ +54 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +54 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +54 B
Overall change 5.19 MB 5.19 MB ⚠️ +162 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12.2s 12.2s -17ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.988 2.027 ⚠️ +0.04
/ avg req/sec 1257.61 1233.31 ⚠️ -24.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.262 1.294 ⚠️ +0.03
/error-in-render avg req/sec 1981.48 1931.67 ⚠️ -49.81
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
597-c48889ef..1870.js gzip 13 kB 13 kB ⚠️ +7 B
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.9 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 587 B 586 B -1 B
link.html gzip 591 B 593 B ⚠️ +2 B
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ⚠️ +1 B

Diffs

Diff for 677f882d2ed8..c23f838ed.js 
@@ -1654,7 +1654,7 @@
               value: function(t) {
                 var e = t.split("#"),
                   r = u(e, 2)[1];
-                if ("" !== r) {
+                if ("" !== r && "top" !== r) {
                   var n = document.getElementById(r);
                   if (n) n.scrollIntoView();
                   else {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "j5nAX14b41s2ts36KfdWv",
+        "buildId": "11rQyncyaOoGuE-OhCE9o",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/j5nAX14b41s2ts36KfdWv/_buildManifest.js"
+      src="/_next/static/11rQyncyaOoGuE-OhCE9o/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/j5nAX14b41s2ts36KfdWv/_ssgManifest.js"
+      src="/_next/static/11rQyncyaOoGuE-OhCE9o/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "j5nAX14b41s2ts36KfdWv",
+        "buildId": "11rQyncyaOoGuE-OhCE9o",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/j5nAX14b41s2ts36KfdWv/_buildManifest.js"
+      src="/_next/static/11rQyncyaOoGuE-OhCE9o/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/j5nAX14b41s2ts36KfdWv/_ssgManifest.js"
+      src="/_next/static/11rQyncyaOoGuE-OhCE9o/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "j5nAX14b41s2ts36KfdWv",
+        "buildId": "11rQyncyaOoGuE-OhCE9o",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/j5nAX14b41s2ts36KfdWv/_buildManifest.js"
+      src="/_next/static/11rQyncyaOoGuE-OhCE9o/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/j5nAX14b41s2ts36KfdWv/_ssgManifest.js"
+      src="/_next/static/11rQyncyaOoGuE-OhCE9o/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f6961fe

@Timer Timer dismissed stale reviews from timneutkens and themself via ea596a6 January 29, 2021 19:49
@ijjk
Copy link
Member

ijjk commented Jan 29, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 9.9s 10.2s ⚠️ +279ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.99 1.983 -0.01
/ avg req/sec 1256.32 1260.59 +4.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.219 1.236 ⚠️ +0.02
/error-in-render avg req/sec 2050.32 2022.28 ⚠️ -28.04
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ⚠️ +5 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓

Diffs

Diff for 677f882d2ed8..dde534236.js 
@@ -2840,9 +2840,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12s 11.6s -442ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..49c4.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.5 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ⚠️ +54 B
routerDirect.js 1.05 MB 1.06 MB ⚠️ +54 B
withRouter.js 1.05 MB 1.06 MB ⚠️ +54 B
Overall change 5.19 MB 5.19 MB ⚠️ +162 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 12s 12.1s ⚠️ +95ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Page Load Tests Overall increase ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.928 1.925 0
/ avg req/sec 1296.74 1298.44 +1.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.219 1.204 -0.02
/error-in-render avg req/sec 2050.84 2076.22 +25.38
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
597-7c719119..27b6.js gzip 13 kB 13 kB ⚠️ +7 B
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 586 B 585 B -1 B
link.html gzip 592 B 593 B ⚠️ +1 B
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for 677f882d2ed8..c23f838ed.js 
@@ -1654,7 +1654,7 @@
               value: function(t) {
                 var e = t.split("#"),
                   r = u(e, 2)[1];
-                if ("" !== r) {
+                if ("" !== r && "top" !== r) {
                   var n = document.getElementById(r);
                   if (n) n.scrollIntoView();
                   else {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "lF_dYkAKfwXgP3pPWeqsn",
+        "buildId": "Pb-Xr1QtG3_WAzQ1rmZEn",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/lF_dYkAKfwXgP3pPWeqsn/_buildManifest.js"
+      src="/_next/static/Pb-Xr1QtG3_WAzQ1rmZEn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/lF_dYkAKfwXgP3pPWeqsn/_ssgManifest.js"
+      src="/_next/static/Pb-Xr1QtG3_WAzQ1rmZEn/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "lF_dYkAKfwXgP3pPWeqsn",
+        "buildId": "Pb-Xr1QtG3_WAzQ1rmZEn",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/lF_dYkAKfwXgP3pPWeqsn/_buildManifest.js"
+      src="/_next/static/Pb-Xr1QtG3_WAzQ1rmZEn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/lF_dYkAKfwXgP3pPWeqsn/_ssgManifest.js"
+      src="/_next/static/Pb-Xr1QtG3_WAzQ1rmZEn/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "lF_dYkAKfwXgP3pPWeqsn",
+        "buildId": "Pb-Xr1QtG3_WAzQ1rmZEn",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/lF_dYkAKfwXgP3pPWeqsn/_buildManifest.js"
+      src="/_next/static/Pb-Xr1QtG3_WAzQ1rmZEn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/lF_dYkAKfwXgP3pPWeqsn/_ssgManifest.js"
+      src="/_next/static/Pb-Xr1QtG3_WAzQ1rmZEn/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ea596a6

Timer
Timer previously approved these changes Jan 30, 2021
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Jan 30, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 8.7s 8.5s -262ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Page Load Tests Overall increase ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.685 1.715 ⚠️ +0.03
/ avg req/sec 1483.52 1457.88 ⚠️ -25.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.064 1.032 -0.03
/error-in-render avg req/sec 2349.57 2423.1 +73.53
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ⚠️ +5 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 613 B 613 B ✓
link.html gzip 618 B 619 B ⚠️ +1 B
withRouter.html gzip 606 B 607 B ⚠️ +1 B
Overall change 1.84 kB 1.84 kB ⚠️ +2 B

Diffs

Diff for 677f882d2ed8..dde534236.js 
@@ -2840,9 +2840,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 10.3s 10.5s ⚠️ +229ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..49c4.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.4 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ⚠️ +54 B
routerDirect.js 1.05 MB 1.06 MB ⚠️ +54 B
withRouter.js 1.05 MB 1.06 MB ⚠️ +54 B
Overall change 5.19 MB 5.19 MB ⚠️ +162 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 10.6s 10.7s ⚠️ +156ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.683 1.683 ✓
/ avg req/sec 1485.36 1485.53 +0.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.083 1.122 ⚠️ +0.04
/error-in-render avg req/sec 2308.63 2227.51 ⚠️ -81.12
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
597-7c719119..27b6.js gzip 13 kB 13 kB ⚠️ +7 B
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.57 kB 6.57 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 586 B 584 B -2 B
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 577 B -2 B
Overall change 1.76 kB 1.75 kB -4 B

Diffs

Diff for 677f882d2ed8..c23f838ed.js 
@@ -1654,7 +1654,7 @@
               value: function(t) {
                 var e = t.split("#"),
                   r = u(e, 2)[1];
-                if ("" !== r) {
+                if ("" !== r && "top" !== r) {
                   var n = document.getElementById(r);
                   if (n) n.scrollIntoView();
                   else {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "elZWEqEa-9GHVFmXh_Wjg",
+        "buildId": "bVF2sEoItJQaeiwmndj_2",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/elZWEqEa-9GHVFmXh_Wjg/_buildManifest.js"
+      src="/_next/static/bVF2sEoItJQaeiwmndj_2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/elZWEqEa-9GHVFmXh_Wjg/_ssgManifest.js"
+      src="/_next/static/bVF2sEoItJQaeiwmndj_2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "elZWEqEa-9GHVFmXh_Wjg",
+        "buildId": "bVF2sEoItJQaeiwmndj_2",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/elZWEqEa-9GHVFmXh_Wjg/_buildManifest.js"
+      src="/_next/static/bVF2sEoItJQaeiwmndj_2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/elZWEqEa-9GHVFmXh_Wjg/_ssgManifest.js"
+      src="/_next/static/bVF2sEoItJQaeiwmndj_2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "elZWEqEa-9GHVFmXh_Wjg",
+        "buildId": "bVF2sEoItJQaeiwmndj_2",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/elZWEqEa-9GHVFmXh_Wjg/_buildManifest.js"
+      src="/_next/static/bVF2sEoItJQaeiwmndj_2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/elZWEqEa-9GHVFmXh_Wjg/_ssgManifest.js"
+      src="/_next/static/bVF2sEoItJQaeiwmndj_2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 3c87525

@ijjk
Copy link
Member

ijjk commented Jan 30, 2021

Failing test suites

Commit: 3c87525

test/integration/build-output/test/index.test.js

  • Build Output > Basic Application Output > should not deviate from snapshot
Expand output

● Build Output › Basic Application Output › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 63.6
Received: 63.5

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.10000000000000142

  105 |       expect(err404FirstLoad.endsWith('kB')).toBe(true)
  106 | 
> 107 |       expect(parseFloat(sharedByAll)).toBeCloseTo(63.6, 1)
      |                                       ^
  108 |       expect(sharedByAll.endsWith('kB')).toBe(true)
  109 | 
  110 |       if (_appSize.endsWith('kB')) {

  at Object.<anonymous> (integration/build-output/test/index.test.js:107:39)

@ijjk
Copy link
Member

ijjk commented Jan 30, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 11.4s 11.5s ⚠️ +112ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Page Load Tests Overall increase ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.343 2.296 -0.05
/ avg req/sec 1066.79 1088.69 +21.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.617 1.628 ⚠️ +0.01
/error-in-render avg req/sec 1546 1536.08 ⚠️ -9.92
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ⚠️ +5 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 613 B 613 B ✓
link.html gzip 618 B 619 B ⚠️ +1 B
withRouter.html gzip 606 B 607 B ⚠️ +1 B
Overall change 1.84 kB 1.84 kB ⚠️ +2 B

Diffs

Diff for 677f882d2ed8..dde534236.js 
@@ -2840,9 +2840,10 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             value: function scrollToHash(as) {
               var _as$split3 = as.split("#"),
                 _as$split4 = _slicedToArray(_as$split3, 2),
-                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value
+                hash = _as$split4[1]; // Scroll to top if the hash is just `#` with no value or `#top`
+              // To mirror browsers
 
-              if (hash === "") {
+              if (hash === "" || hash === "top") {
                 window.scrollTo(0, 0);
                 return;
               } // First we check if the element by id is found
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d59cca9b248dde534236.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
       async=""
     ></script>
     <script
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 13.6s 13.3s -274ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
677f882d2ed8..38ed.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..49c4.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.4 kB ⚠️ +5 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ⚠️ +54 B
routerDirect.js 1.05 MB 1.06 MB ⚠️ +54 B
withRouter.js 1.05 MB 1.06 MB ⚠️ +54 B
Overall change 5.19 MB 5.19 MB ⚠️ +162 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
buildDuration 13.7s 13.5s -158ms
nodeModulesSize 75 MB 75 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.231 2.285 ⚠️ +0.05
/ avg req/sec 1120.39 1094.05 ⚠️ -26.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.548 1.57 ⚠️ +0.02
/error-in-render avg req/sec 1614.61 1592.23 ⚠️ -22.38
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
597-7c719119..27b6.js gzip 13 kB 13 kB ⚠️ +7 B
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.57 kB 6.57 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ⚠️ +7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary lebreRafael/next.js anchor_scroll Change
index.html gzip 586 B 584 B -2 B
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 577 B -2 B
Overall change 1.76 kB 1.75 kB -4 B

Diffs

Diff for 677f882d2ed8..c23f838ed.js 
@@ -1654,7 +1654,7 @@
               value: function(t) {
                 var e = t.split("#"),
                   r = u(e, 2)[1];
-                if ("" !== r) {
+                if ("" !== r && "top" !== r) {
                   var n = document.getElementById(r);
                   if (n) n.scrollIntoView();
                   else {
Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "obcu081Cm75TtiHOzd13C",
+        "buildId": "4JyXY4NGPza_zSjLI4S9L",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/obcu081Cm75TtiHOzd13C/_buildManifest.js"
+      src="/_next/static/4JyXY4NGPza_zSjLI4S9L/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/obcu081Cm75TtiHOzd13C/_ssgManifest.js"
+      src="/_next/static/4JyXY4NGPza_zSjLI4S9L/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "obcu081Cm75TtiHOzd13C",
+        "buildId": "4JyXY4NGPza_zSjLI4S9L",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/obcu081Cm75TtiHOzd13C/_buildManifest.js"
+      src="/_next/static/4JyXY4NGPza_zSjLI4S9L/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/obcu081Cm75TtiHOzd13C/_ssgManifest.js"
+      src="/_next/static/4JyXY4NGPza_zSjLI4S9L/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "obcu081Cm75TtiHOzd13C",
+        "buildId": "4JyXY4NGPza_zSjLI4S9L",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c28076628b4c23f838ed.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/obcu081Cm75TtiHOzd13C/_buildManifest.js"
+      src="/_next/static/4JyXY4NGPza_zSjLI4S9L/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/obcu081Cm75TtiHOzd13C/_ssgManifest.js"
+      src="/_next/static/4JyXY4NGPza_zSjLI4S9L/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: aea8a3f

@kodiakhq kodiakhq bot merged commit 60e6995 into vercel:canary Jan 30, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@timneutkens timneutkens timneutkens left review comments

@lfades lfades lfades left review comments

@ijjk ijjk Awaiting requested review from ijjk

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lebreRafael @ijjk @Timer @lfades @timneutkens