[next 14] logging.fetches.fullUrl condition is inverted: everyone has full logs ON (a PR to fix it is linked) #58087
Comments
huozhi
added a commit
that referenced
this issue
Dec 7, 2023
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes #58087 --> fixes #58087 Currently in Next 14, everyone has fullURL flag turned to true, this PR reverts the condition. --------- Co-authored-by: Jiachi Liu <inbox@huozhi.im>
|
This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Link to the code that reproduces this issue
https://github.com/raphaelbadia/nextjs-appdir-truncates-logs
To Reproduce
Current vs. Expected behavior
I expect the URLs to be fully shown, not truncated.
The condition is currently inverted : everyone using nextjs 14 has full URLs logged.
Verify canary release
Provide environment information
Operating System: Platform: darwin Arch: x64 Version: Darwin Kernel Version 22.3.0: Mon Jan 30 20:39:46 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6020 Binaries: Node: 18.18.2 npm: 9.8.1 Yarn: 1.22.19 pnpm: 8.9.2 Relevant Packages: next: 13.4.9-canary.1 eslint-config-next: N/A react: 18.2.0 react-dom: 18.2.0 typescript: 4.9.5 Next.js Config: output: N/A warn - Latest canary version not detected, detected: "13.4.9-canary.1", newest: "14.0.2-canary.13". Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue. Read more - https://nextjs.org/docs/messages/opening-an-issue ✨ Done in 2.38s.Which area(s) are affected? (Select all that apply)
App Router
Additional context
I read nextjs's source and realised the condition in
packages/next/src/server/next-server.tsis wrong. I've inverted it in this PR : #58088The text was updated successfully, but these errors were encountered: