Improve CSS Server Side Compilation #52208
Comments
shuding
added a commit
that referenced
this issue
Jul 5, 2023
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change --> ### What? - Use a `cssModules` option to configure the `next-flight-css-loader.ts` based on the match resource. - Added types - Ran prettier ### Why? NextJs supports css modules and global css files. The `next-flight-css-loader.ts` is capable of dealing with both formats. However under the hood the loader shares almost no code for css modules and global css files. To branch into the correct behaviour the `next-flight-css-loader.ts` checks the extension of the file using `this.resourcePath.match(/\.module\.(css|sass|scss)$/)`. `this.resourcePath` does not include the information from webpacks `!=!` import syntax. One solution would be to use `this._module.matchResource` instead of `this.resourcePath`. But imho passing it from the webpack.config.js instead of duplicating the css module file regexp felt cleaner. ### Further questions - Should we update the loader banner comment? - Can we drop `this.data.__checksum` in the pitch loader function for css modules? (it would speed up css modules and for me it looks like it isn't needed anymore for css modules because of 2eeb0c7 (4. April by @shuding) - Should we split the loader into two loaders? Fixes #52208 --------- Co-authored-by: Shu Ding <g@shud.in>
shuding
added a commit
that referenced
this issue
Jul 8, 2023
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change --> ### What? - Use a `cssModules` option to configure the `next-flight-css-loader.ts` based on the match resource. - Added types - Ran prettier ### Why? NextJs supports css modules and global css files. The `next-flight-css-loader.ts` is capable of dealing with both formats. However under the hood the loader shares almost no code for css modules and global css files. To branch into the correct behaviour the `next-flight-css-loader.ts` checks the extension of the file using `this.resourcePath.match(/\.module\.(css|sass|scss)$/)`. `this.resourcePath` does not include the information from webpacks `!=!` import syntax. One solution would be to use `this._module.matchResource` instead of `this.resourcePath`. But imho passing it from the webpack.config.js instead of duplicating the css module file regexp felt cleaner. ### Further questions - Should we update the loader banner comment? - Can we drop `this.data.__checksum` in the pitch loader function for css modules? (it would speed up css modules and for me it looks like it isn't needed anymore for css modules because of 2eeb0c7 (4. April by @shuding) - Should we split the loader into two loaders? Fixes #52208 --------- Co-authored-by: Shu Ding <g@shud.in>
|
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Verify canary release
On Dec 15, 2022 the cache busting logic of the
packages/next/src/build/webpack/loaders/next-flight-css-loader.tswas changed in 64d3ba5Currently, despite the changes, the previous cache busting logic remains intact, leading to a suboptimal situation. There are a two reasons why this is problematic imho:
Redundant Disk Reads: With the existing cache busting logic, every CSS file needs to be read from the disk once again. This results in unnecessary disk I/O operations, which can impact performance, particularly in larger applications where the number of CSS files is substantial.
Unused Information: Furthermore, the information obtained through this cache busting logic is not utilized at all. This implies that the additional disk reads serve no purpose and do not contribute to the functionality or efficiency of the application.
I prepared a PR to delete the obsolete pitch loader and make use of webpacks built in resource matcher.
Could you please review the PR #51115 and provide any feedback or suggestions for further improvement?
Provide environment information
Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 22.5.0: Mon Apr 24 20:52:24 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T6000 Binaries: Node: 18.16.0 npm: 9.5.1 Yarn: 3.2.3 pnpm: N/A Relevant packages: next: 13.2.4 eslint-config-next: N/A react: 18.2.0 react-dom: 18.2.0The text was updated successfully, but these errors were encountered: