Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error routes (404, 500) in React Server Components #30989

Closed
leerob opened this issue Nov 4, 2021 · 1 comment · Fixed by #31164
Closed

Error routes (404, 500) in React Server Components #30989

leerob opened this issue Nov 4, 2021 · 1 comment · Fixed by #31164
Assignees
@huozhi

Comments

@leerob
Copy link
Member

leerob commented Nov 4, 2021

Describe the feature you'd like to request

Support for these features, with correct status codes.

https://nextjs.org/docs/advanced-features/custom-error-page

Describe the solution you'd like

TBD

Describe alternatives you've considered

N/A
@huozhi huozhi mentioned this issue Nov 5, 2021
Merged
2 tasks
kodiakhq bot pushed a commit that referenced this issue Nov 6, 2021
@huozhi
Fix custom 404 page when concurrentFeatures is enabled (#31059)
e029ace 
x-ref: #30424 (comment)

This fix the custom 404 is not rendering properly and can’t be built in web runtime when `concurrentFeatures` is enabled. We force 404 page to be rendered outside of middleware ssr. Then it could be the real fallback 404 page in next-server when any routes is not macthed. 
Will check 500 related after #31057 is landed.

## Bug

- [x] Related to #30989
- [x] Integration tests added
@huozhi huozhi self-assigned this Nov 8, 2021
@huozhi huozhi mentioned this issue Nov 15, 2021
Merged
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@huozhi huozhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close stream when fatal error occurs huozhi/next.js
4 participants
@huozhi @timneutkens @leerob @balazsorban44