Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite for / doesn't match with i18n on a non-locale: false rewrite #20508

Closed
ijjk opened this issue Dec 27, 2020 · 1 comment · Fixed by #20509
Closed

Rewrite for / doesn't match with i18n on a non-locale: false rewrite #20508

ijjk opened this issue Dec 27, 2020 · 1 comment · Fixed by #20509
Assignees
@ijjk
Milestone
iteration 15

Comments

@ijjk
Copy link
Member

ijjk commented Dec 27, 2020

When rewriting the / route with i18n enabled we need to ensure the value is built correctly when generating the locale version of the rewrite source i.e. when not using locale: false
@ijjk ijjk added the bug Issue was opened via the bug report template. label Dec 27, 2020
@ijjk ijjk mentioned this issue Dec 27, 2020
Merged
@ijjk ijjk added kind: bug and removed bug Issue was opened via the bug report template. labels Dec 27, 2020
@ijjk ijjk self-assigned this Dec 27, 2020
@Timer Timer added this to the iteration 15 milestone Dec 28, 2020
@kodiakhq kodiakhq bot closed this as completed in #20509 Dec 28, 2020
kodiakhq bot pushed a commit that referenced this issue Dec 28, 2020
@ijjk
Ensure index rewrite is matched with i18n correctly (#20509)
db329fe 
This makes sure we don't generate the wrong locale source variant for the rewrite requiring a `/` on the end which won't ever be added causing the rewrite to never match. Additional tests have been added to ensure this specific rewrite is working correctly. 


Fixes: #20508
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 15
Development

Successfully merging a pull request may close this issue.

Ensure index rewrite is matched with i18n correctly ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk