Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add example for headers #15073

Closed
3 tasks done
lfades opened this issue Jul 11, 2020 · 6 comments
Closed
3 tasks done

[Docs] Add example for headers #15073

lfades opened this issue Jul 11, 2020 · 6 comments
Labels
examples Issue was opened via the examples template. good first issue Easy to fix issues, good for newcomers
Milestone

Comments

@lfades
Copy link
Member

lfades commented Jul 11, 2020

Documentation for custom routes was released some days ago (#14887). We should also add one example for every documentation page to better show how it works.

The following three examples are required:

Every example should contain very basic content and focus only on the feature it's about, showing how it works for multiple use cases that are currently not covered by the documentation. After the example is complete, add a link to it at the beginning of the page in docs.

Feel free to open a PR and I'll review it asap.

@lfades lfades added good first issue Easy to fix issues, good for newcomers examples Issue was opened via the examples template. type: documentation labels Jul 11, 2020
@robintom
Copy link
Contributor

Hey @lfades could you assign this to me? I can work on this! :)

@khattakdev
Copy link
Contributor

@robintom I would love to work on this if you didn't start yet.

@robintom
Copy link
Contributor

@ekhattak Sorry, i did already start working on it. I will be making a PR soon.

@lfades
Copy link
Member Author

lfades commented Jul 20, 2020

@robintom If possible please make a PR per example, don't merge all of them on a single one.

kodiakhq bot pushed a commit that referenced this issue Jul 25, 2020
This PR adds example for #15073  
> - [ ] `rewrites` For [docs/api-reference/next.config.js/rewrites.md](https://github.com/vercel/next.js/blob/canary/docs/api-reference/next.config.js/rewrites.md)
kodiakhq bot pushed a commit that referenced this issue Aug 5, 2020
This PR adds example for #15073 
> - [ ] `redirects` For [docs/api-reference/next.config.js/redirects.md](https://github.com/vercel/next.js/blob/canary/docs/api-reference/next.config.js/redirects.md)
@Timer Timer added this to the backlog milestone Sep 7, 2020
@leerob leerob changed the title [Docs] Add examples for custom routes [Docs] Add example for headers Feb 1, 2021
@styfle
Copy link
Member

styfle commented Nov 23, 2021

Looks like these are all complete now, closing 👍

@styfle styfle closed this as completed Nov 23, 2021
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants